Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(177)

Issue 6845051: Exporting more DOM interface names; assorted cleanup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by kpreid2
Modified:
1 year, 5 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* <canvas>.getContext() returns null (per spec) rather than undefined
  (per obsolete browser behavior observations) on failure.
* TameCustomEvents did not get confided as TameEvent (so operations on
  them were mostly broken) unless the browser supported proxies.
* TameWindow did not get inertCtor'd, allowing guests to create new
  Window objects (this does not include interesting excess authority).
* Export interfaces Document, Window, Event. In order to export Window
  we had to reorder the full definition of TameWindow to before freezing
  of exported classes, which should be harmless but is a notable change.
* Comment interface was incorrectly named CommentNode.
* toString is implemented better and includes nodeName for the sake of
  debugging since WebKit console provides it over toString, but of
  course not for our tame nodes.
* Enable disabled test-domado-dom-guest testToString.

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -92 lines) Patch
M src/com/google/caja/plugin/domado.js View 9 chunks +67 lines, -78 lines 3 comments Download
M tests/com/google/caja/plugin/es53-test-domado-canvas-guest.html View 1 chunk +1 line, -1 line 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 1 chunk +52 lines, -13 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-foreign-guest.html View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3
kpreid2
1 year, 5 months ago #1
felix8a
lgtm https://codereview.appspot.com/6845051/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/6845051/diff/1/src/com/google/caja/plugin/domado.js#newcode2965 src/com/google/caja/plugin/domado.js:2965: setOwn(TameNode.prototype, "toString", cajaVM.def(function (opt_self) { opt_self is no ...
1 year, 5 months ago #2
kpreid2
1 year, 5 months ago #3
@r5153

https://codereview.appspot.com/6845051/diff/1/src/com/google/caja/plugin/doma...
File src/com/google/caja/plugin/domado.js (right):

https://codereview.appspot.com/6845051/diff/1/src/com/google/caja/plugin/doma...
src/com/google/caja/plugin/domado.js:2965: setOwn(TameNode.prototype,
"toString", cajaVM.def(function (opt_self) {
On 2012/11/16 14:52:41, felix8a wrote:
> opt_self is no longer used

Done.

https://codereview.appspot.com/6845051/diff/1/src/com/google/caja/plugin/doma...
src/com/google/caja/plugin/domado.js:5855: setOwn(TameWindow.prototype,
"toString", cajaVM.def(function () {
Also changed this to function() per code style.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5