Add SkMatrix44::setTranspose

Add SkMatrix44::setTranspose

It turned out that adding getDouble(...) and setDouble(...) made this change
easier, so I've included that in this cl as well.

Committed: https://code.google.com/p/skia/source/detail?r=6424

[reed1, 2012-11-14 15:55:28]

https://codereview.appspot.com/6845048/diff/2001/include/utils/SkMatrix44.h
File include/utils/SkMatrix44.h (right):

https://codereview.appspot.com/6845048/diff/2001/include/utils/SkMatrix44.h#n...
include/utils/SkMatrix44.h:176: /** Sets this to its transpose. */
The skia naming convention would be:

/**
 * Transpose this matrix in place
 */
void transpose();

/**
 * Replace this matrix with the transpose of other. It is legal for other and
this
 * matrix to be the same.
 */
void setTranspose(const SkMatrix44& other);

https://codereview.appspot.com/6845048/diff/2001/src/utils/SkMatrix44.cpp
File src/utils/SkMatrix44.cpp (right):

https://codereview.appspot.com/6845048/diff/2001/src/utils/SkMatrix44.cpp#new...
src/utils/SkMatrix44.cpp:211: void SkMatrix44::setTranspose() {
Use SkTSwap instead of pulling in STL.

[vollick, 2012-11-14 19:20:30]

On 2012/11/14 15:55:28, reed1 wrote:
> https://codereview.appspot.com/6845048/diff/2001/include/utils/SkMatrix44.h
> File include/utils/SkMatrix44.h (right):
> 
>
https://codereview.appspot.com/6845048/diff/2001/include/utils/SkMatrix44.h#n...
> include/utils/SkMatrix44.h:176: /** Sets this to its transpose. */
> The skia naming convention would be:
> 
> /**
>  * Transpose this matrix in place
>  */
> void transpose();
> 
> /**
>  * Replace this matrix with the transpose of other. It is legal for other and
> this
>  * matrix to be the same.
>  */
> void setTranspose(const SkMatrix44& other);
> 
I've updated the name of setTranspose to transpose as you've suggested. I also
started by writing setTranspose, but after having written it, it didn't seem to
add too much value to me, so I removed it. Please let me know if you'd like to
see both in the API.
> https://codereview.appspot.com/6845048/diff/2001/src/utils/SkMatrix44.cpp
> File src/utils/SkMatrix44.cpp (right):
> 
>
https://codereview.appspot.com/6845048/diff/2001/src/utils/SkMatrix44.cpp#new...
> src/utils/SkMatrix44.cpp:211: void SkMatrix44::setTranspose() {
> Use SkTSwap instead of pulling in STL.

Done.

[reed1, 2012-11-14 20:51:31]

lgtm w/ nits about style (this->)

https://codereview.appspot.com/6845048/diff/7001/include/utils/SkMatrix44.h
File include/utils/SkMatrix44.h (right):

https://codereview.appspot.com/6845048/diff/7001/include/utils/SkMatrix44.h#n...
include/utils/SkMatrix44.h:122: double getDouble(int row, int col) const {
When an object calls its own method, we typically preceed that with this->

    this->get(row, col)

https://codereview.appspot.com/6845048/diff/7001/include/utils/SkMatrix44.h#n...
include/utils/SkMatrix44.h:125: void setDouble(int row, int col, double value) {
  this->set(row, col, ...)

[vollick, 2012-11-14 21:33:45]

On 2012/11/14 20:51:31, reed1 wrote:
> lgtm w/ nits about style (this->)
> 
> https://codereview.appspot.com/6845048/diff/7001/include/utils/SkMatrix44.h
> File include/utils/SkMatrix44.h (right):
> 
>
https://codereview.appspot.com/6845048/diff/7001/include/utils/SkMatrix44.h#n...
> include/utils/SkMatrix44.h:122: double getDouble(int row, int col) const {
> When an object calls its own method, we typically preceed that with this->
> 
>     this->get(row, col)
Done.
> 
>
https://codereview.appspot.com/6845048/diff/7001/include/utils/SkMatrix44.h#n...
> include/utils/SkMatrix44.h:125: void setDouble(int row, int col, double value)
{
>   this->set(row, col, ...)

Done.