Issue 6844105: Write correct type of sfnt file in mac coretext open stream.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6844105: Write correct type of sfnt file in mac coretext open stream. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 9 months ago by bungeman

Modified:
11 years, 9 months ago

Reviewers:
caryclark1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Write correct type of sfnt file in mac coretext open stream.

Patch Set 2 : Address comments. #

Created: 11 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -47 lines)			Patch
	M	src/ports/SkFontHost_mac_coretext.cpp	View	1	3 chunks	+63 lines, -47 lines	0 comments	Download

Messages

Total messages: 5

Expand All Messages | Collapse All Messages

bungeman

Writes the correct fontType in the sfnt header. Also updates existing code in OpenStream to ...

11 years, 9 months ago (2012-11-28 20:23:55 UTC) #1

caryclark1

https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode1674 src/ports/SkFontHost_mac_coretext.cpp:1674: //CFNumberType type = CFNumberGetType(fontFormatNumberRef); //returns kCFNumberSInt32Type should this be ...

11 years, 9 months ago (2012-11-28 20:31:30 UTC) #2

bungeman

Comments addressed. https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode1674 src/ports/SkFontHost_mac_coretext.cpp:1674: //CFNumberType type = CFNumberGetType(fontFormatNumberRef); //returns kCFNumberSInt32Type On ...

11 years, 9 months ago (2012-11-28 20:45:14 UTC) #3

bungeman

11 years, 9 months ago (2012-11-28 23:41:28 UTC) #5

Committed revision 6590.
Bogus assert removed with revision 6592.

Expand All Messages | Collapse All Messages