https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode1674 src/ports/SkFontHost_mac_coretext.cpp:1674: //CFNumberType type = CFNumberGetType(fontFormatNumberRef); //returns kCFNumberSInt32Type should this be ...
11 years, 9 months ago
(2012-11-28 20:31:30 UTC)
#2
Comments addressed. https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp File src/ports/SkFontHost_mac_coretext.cpp (right): https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_coretext.cpp#newcode1674 src/ports/SkFontHost_mac_coretext.cpp:1674: //CFNumberType type = CFNumberGetType(fontFormatNumberRef); //returns kCFNumberSInt32Type On ...
11 years, 9 months ago
(2012-11-28 20:45:14 UTC)
#3
Comments addressed.
https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_corete...
File src/ports/SkFontHost_mac_coretext.cpp (right):
https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_corete...
src/ports/SkFontHost_mac_coretext.cpp:1674: //CFNumberType type =
CFNumberGetType(fontFormatNumberRef); //returns kCFNumberSInt32Type
On 2012/11/28 20:31:30, caryclark1 wrote:
> should this be
> SkASSERT(CFNumberGetType(fontFormatNumberRef) == kCFNumberSInt32Type);
> ?
Done. I was afraid that the size would change when in 64 bit, but it turns out
this is always an SInt32.
https://codereview.appspot.com/6844105/diff/1/src/ports/SkFontHost_mac_corete...
src/ports/SkFontHost_mac_coretext.cpp:1677: return 0;
On 2012/11/28 20:31:30, caryclark1 wrote:
> does an early return here leak a fontFormatRef ?
Yes, I actually back formed this patch out of one where I have an auto release
template for these. Will add release here until that can be added.
Issue 6844105: Write correct type of sfnt file in mac coretext open stream.
(Closed)
Created 11 years, 9 months ago by bungeman
Modified 11 years, 9 months ago
Reviewers: caryclark1
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 4