Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3403)

Issue 6844104: Update gm self-test to pass again after r6585 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by epoger
Modified:
11 years, 7 months ago
Reviewers:
EricB, robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Update gm self-test to pass again after r6585 Now depends on only "dashing2" test, not all tests whose name starts with "dashing", so it should be more resilient in the face of further changes. TBR=borenet,robertphillips Committed: https://code.google.com/p/skia/source/detail?r=6588

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -32 lines) Patch
D gm/tests/inputs/dashing-correct-images/4444/dashing.png View Binary file 0 comments Download
D gm/tests/inputs/dashing-correct-images/4444/dashing2.png View Binary file 0 comments Download
D gm/tests/inputs/dashing-incorrect-images/4444/dashing.png View Binary file 0 comments Download
D gm/tests/inputs/dashing-incorrect-images/4444/dashing2.png View Binary file 0 comments Download
A gm/tests/inputs/different-pixels/4444/dashing2.png View Binary file 0 comments Download
A gm/tests/outputs/compared-against-different-pixels/output-expected/command_line View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/compared-against-different-pixels/output-expected/images/4444/dashing2.png View Binary file 0 comments Download
A gm/tests/outputs/compared-against-different-pixels/output-expected/return_value View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/compared-against-different-pixels/output-expected/stdout View 1 chunk +6 lines, -0 lines 0 comments Download
M + gm/tests/outputs/compared-against-identical-bytes/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
M + gm/tests/outputs/compared-against-identical-bytes/output-expected/stdout View 1 chunk +3 lines, -4 lines 0 comments Download
M + gm/tests/outputs/compared-against-identical-pixels/output-expected/command_line View 1 chunk +1 line, -1 line 0 comments Download
D gm/tests/outputs/compared-against-identical-pixels/output-expected/images/4444/dashing.png View Binary file 0 comments Download
M + gm/tests/outputs/compared-against-identical-pixels/output-expected/return_value View 1 chunk +1 line, -1 line 0 comments Download
M + gm/tests/outputs/compared-against-identical-pixels/output-expected/stdout View 1 chunk +3 lines, -6 lines 0 comments Download
D gm/tests/outputs/dashing-compared-against-correct/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/dashing-compared-against-correct/output-expected/images/4444/dashing.png View Binary file 0 comments Download
D gm/tests/outputs/dashing-compared-against-correct/output-expected/images/4444/dashing2.png View Binary file 0 comments Download
D gm/tests/outputs/dashing-compared-against-correct/output-expected/return_value View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/dashing-compared-against-correct/output-expected/stdout View 1 chunk +0 lines, -5 lines 0 comments Download
D gm/tests/outputs/dashing-compared-against-incorrect/output-expected/command_line View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/dashing-compared-against-incorrect/output-expected/images/4444/dashing.png View Binary file 0 comments Download
D gm/tests/outputs/dashing-compared-against-incorrect/output-expected/images/4444/dashing2.png View Binary file 0 comments Download
D gm/tests/outputs/dashing-compared-against-incorrect/output-expected/return_value View 1 chunk +0 lines, -1 line 0 comments Download
D gm/tests/outputs/dashing-compared-against-incorrect/output-expected/stdout View 1 chunk +0 lines, -7 lines 0 comments Download
M gm/tests/run.sh View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 2
epoger
11 years, 7 months ago (2012-11-28 20:08:16 UTC) #1
EricB
11 years, 7 months ago (2012-11-28 20:14:21 UTC) #2
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b