Update filter tool to write out paths to .cpp file

Update filter tool to write out paths to .cpp file

[DerekS, 2012-11-29 20:53:15]

https://codereview.appspot.com/6843125/diff/1001/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6843125/diff/1001/tools/filtermain.cpp#newcode46
tools/filtermain.cpp:46: static void dump_path_prefix(SkFILEWStream* pathStream)
{
I think we should move the path generator into it's own file to make the
separation cleaner.

[robertphillips, 2012-12-07 14:32:43]

https://codereview.appspot.com/6843125/diff/1001/tools/filtermain.cpp
File tools/filtermain.cpp (right):

https://codereview.appspot.com/6843125/diff/1001/tools/filtermain.cpp#newcode46
tools/filtermain.cpp:46: static void dump_path_prefix(SkFILEWStream* pathStream)
{
On 2012/11/29 20:53:16, DerekS wrote:
> I think we should move the path generator into it's own file to make the
> separation cleaner.

Done.

[DerekS, 2012-12-07 17:34:52]

lgtm with one nit.

https://codereview.appspot.com/6843125/diff/5001/tools/path_utils.cpp
File tools/path_utils.cpp (right):

https://codereview.appspot.com/6843125/diff/5001/tools/path_utils.cpp#newcode13
tools/path_utils.cpp:13: static int gCurPathID = 0;
having this as a global seems fragile since you can't call these helper
functions more than 1x without causing problems.  In particular the
dump_path_suffix function would have problems.  My suggestion is to just
document that you can only call it one time per run of the program or just
document that it isn't thread safe and provide a reset function.

[robertphillips, 2012-12-07 20:56:33]

committed as r6714

https://codereview.appspot.com/6843125/diff/5001/tools/path_utils.cpp
File tools/path_utils.cpp (right):

https://codereview.appspot.com/6843125/diff/5001/tools/path_utils.cpp#newcode13
tools/path_utils.cpp:13: static int gCurPathID = 0;
On 2012/12/07 17:34:52, DerekS wrote:
> having this as a global seems fragile since you can't call these helper
> functions more than 1x without causing problems.  In particular the
> dump_path_suffix function would have problems.  My suggestion is to just
> document that you can only call it one time per run of the program or just
> document that it isn't thread safe and provide a reset function.

Done.