Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(452)

Issue 6843122: Improve document.title behavior; cleanup. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by kpreid2
Modified:
13 years, 7 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* Implement HTML5-conformant behavior for document.title if there is no <title> element. * Remove attribute/property "blacklist" code from TameIFrameElement which is no longer necessary since the whitelist is per-attribute. * Move misplaced @param comment for taming membrane parameter. @r5169

Patch Set 1 #

Total comments: 4

Patch Set 2 : Improve document.title behavior; cleanup. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -43 lines) Patch
M src/com/google/caja/plugin/domado.js View 1 7 chunks +18 lines, -39 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-dom-guest.html View 1 2 chunks +12 lines, -4 lines 0 comments Download
M tests/com/google/caja/plugin/es53-test-domado-global.js View 1 chunk +23 lines, -0 lines 0 comments Download

Messages

Total messages: 5
kpreid2
13 years, 7 months ago (2012-11-28 22:56:24 UTC) #1
felix8a
https://codereview.appspot.com/6843122/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/6843122/diff/1/src/com/google/caja/plugin/domado.js#newcode4684 src/com/google/caja/plugin/domado.js:4684: if (attrLc !== 'name' && attrLc !== 'src') { ...
13 years, 7 months ago (2012-11-29 06:39:24 UTC) #2
kpreid2
* Implement HTML5-conformant behavior for document.title if there is no <title> element. * Remove attribute/property ...
13 years, 7 months ago (2012-11-29 20:02:45 UTC) #3
kpreid2
New snapshot. Note changes to testIframeShim. https://codereview.appspot.com/6843122/diff/1/src/com/google/caja/plugin/domado.js File src/com/google/caja/plugin/domado.js (right): https://codereview.appspot.com/6843122/diff/1/src/com/google/caja/plugin/domado.js#newcode4684 src/com/google/caja/plugin/domado.js:4684: if (attrLc !== ...
13 years, 7 months ago (2012-11-29 20:03:08 UTC) #4
felix8a
13 years, 7 months ago (2012-11-29 20:10:42 UTC) #5
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b