environs/ec2: specify public-bucket-region

environs/ec2: specify public-bucket-region

Fixes LP #1083017

Our public bucket, juju-dist, lives in the us-east-1 region and can only be accessed via that endpoint. If you attempt to do so via another endpoint you get an unhelpful 301 error with an xml blob telling you how to request the bucket. The solution is to add a configuration option, with sensible default, to ec2/config.go to specify the region of the public bucket independantly of the private bucket.

https://code.launchpad.net/~dave-cheney/juju-core/052-environs-ec2-always-request-public-tools-from-us-east-1/+merge/136077

(do not edit description out of merge proposal)

[dave_cheney.net, 2012-11-26 02:20:01]

Please take a look.

[dave_cheney.net, 2012-11-26 02:22:45]

Please take a look.

[jameinel, 2012-11-26 05:18:08]

Seems ok. I'm not sure if having a configurable "grab the tools from this
region" is better than providing the tools in all regions. If this is the best
way forward, than LGTM.

https://codereview.appspot.com/6843112/diff/2001/environs/ec2/ec2.go
File environs/ec2/ec2.go (left):

https://codereview.appspot.com/6843112/diff/2001/environs/ec2/ec2.go#oldcode162
environs/ec2/ec2.go:162: }
It seems like if you've connected you might want to reuse s3Unlocked if region
== publicBucketRegion.

Beyond that, having to access us-east-1 from outside of it means paying
bandwidth charges, etc. Is it worthwhile to try and put the tools on all
regions?

[dave_cheney.net, 2012-11-26 05:20:00]

Providing tools in all regions means reserving buckets in a regions. That might
be a good idea. 

On 26/11/2012, at 16:18, john.meinel@canonical.com wrote:

> Seems ok. I'm not sure if having a configurable "grab the tools from
> this region" is better than providing the tools in all regions. If this
> is the best way forward, than LGTM.
> 
> 
> 
> https://codereview.appspot.com/6843112/diff/2001/environs/ec2/ec2.go
> File environs/ec2/ec2.go (left):
> 
>
https://codereview.appspot.com/6843112/diff/2001/environs/ec2/ec2.go#oldcode162
> environs/ec2/ec2.go:162: }
> It seems like if you've connected you might want to reuse s3Unlocked if
> region == publicBucketRegion.
> 
> Beyond that, having to access us-east-1 from outside of it means paying
> bandwidth charges, etc. Is it worthwhile to try and put the tools on all
> regions?
> 
> https://codereview.appspot.com/6843112/

[dave_cheney.net, 2012-11-26 09:43:28]

Please take a look.

[dave_cheney.net, 2012-11-26 09:44:33]

On 2012/11/26 09:43:28, dfc wrote:
> Please take a look.

Requires https://codereview.appspot.com/6851081/ so tests pass on quantal

[dave_cheney.net, 2012-11-26 22:55:36]

Ping ... seeking a second reviewer.

[dave_cheney.net, 2012-11-27 00:08:39]

*** abandoned *** 

due to prereq change, new proposal is here
https://codereview.appspot.com/6854098