Issue 6843073: Make URI comparisons safe up to query parameter reordering.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6843073: Make URI comparisons safe up to query parameter reordering. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 8 months ago by jcgregorio_google

Modified:
12 years, 8 months ago

Reviewers:
jcgregorio_google, Ali Afshar

CC:
google-api-python-client_googlegroups.com

Visibility:
Public.

Patch Set 2 : Update from review comments. #

Patch Set 3 : real update #

Created: 12 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -3 lines)			Patch
	M	tests/test_discovery.py	View	1 2	4 chunks	+20 lines, -3 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

Ali Afshar

https://codereview.appspot.com/6843073/diff/1/tests/test_discovery.py File tests/test_discovery.py (right): https://codereview.appspot.com/6843073/diff/1/tests/test_discovery.py#newcode64 tests/test_discovery.py:64: actual = urlparse.urlparse(actual) Urlparse returns a named tuple, so ...

12 years, 8 months ago (2012-11-16 18:28:41 UTC) #2

Ali Afshar

https://codereview.appspot.com/6843073/diff/1/tests/test_discovery.py File tests/test_discovery.py (right): https://codereview.appspot.com/6843073/diff/1/tests/test_discovery.py#newcode61 tests/test_discovery.py:61: def assertUrisEqual(unittest, expected, actual): Overrides the unittest module in ...

12 years, 8 months ago (2012-11-16 18:29:56 UTC) #3

jcgregorio_google

Done. On 2012/11/16 18:29:56, Ali Afshar wrote: > https://codereview.appspot.com/6843073/diff/1/tests/test_discovery.py > File tests/test_discovery.py (right): > > ...

12 years, 8 months ago (2012-11-16 19:57:34 UTC) #4

jcgregorio_google

12 years, 8 months ago (2012-11-16 20:29:09 UTC) #6

On 2012/11/16 20:01:54, Ali Afshar wrote:
> LGTM

Committed in
http://code.google.com/p/google-api-python-client/source/detail?r=fababa0edae...

Expand All Messages | Collapse All Messages