Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(357)

Issue 6843072: Separable blur: subpixel blurring. We approximate intermediate values of blur for even kernel siz… (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 10 months ago by Stephen White
Modified:
11 years, 10 months ago
Reviewers:
reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Separable blur: subpixel blurring. We approximate intermediate values of blur for even kernel sizes by using a kernel of size N offset to the left in the first pass, a kernel of size N offset to the right in the second pass, and a centered kernel of size N + 1 in the third pass. This required adding support for asymmetrical radii to the box blur. Since this can only be done in the 3-pass blur for separable blurs, we turn off the optimization that drops to low quality for blurs of < 3 pixels. Committed: https://code.google.com/p/skia/source/detail?r=6464

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -15 lines) Patch
M src/effects/SkBlurMask.cpp View 5 chunks +32 lines, -15 lines 0 comments Download

Messages

Total messages: 2
Stephen White
PTAL
11 years, 10 months ago (2012-11-16 16:31:35 UTC) #1
reed1
11 years, 10 months ago (2012-11-16 16:51:44 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b