code review 6842127: net: align deadline fields on 8 byte boundaries

net: align deadline fields on 8 byte boundaries

This is a workaround for issue 599. Assuming the test in
fd_unix_test.go passes, then 64bit atomics should be safe
to use on the deadline fields, nee CL 6855110.

sizeof netFD on 386 is 112 bytes.

[bradfitz, 2012-12-01 02:09:00]

LGTM

https://codereview.appspot.com/6842127/diff/4001/src/pkg/net/fd_unix.go
File src/pkg/net/fd_unix.go (right):

https://codereview.appspot.com/6842127/diff/4001/src/pkg/net/fd_unix.go#newco...
src/pkg/net/fd_unix.go:22: // guarentees they will be aligned so long as the
heap allocator
typo: guarantees

[dave_cheney.net, 2012-12-01 06:31:39]

Hello bradfitz@golang.org, minux.ma@gmail.com, rsc@golang.org (cc:
golang-dev@googlegroups.com),

I'd like you to review this change to
https://code.google.com/p/go

[dave_cheney.net, 2012-12-02 04:40:18]

Tested on arm6, sizeof netFD is 112 bytes (as expected).

[remyoudompheng, 2012-12-02 13:07:35]

Fixing the whole toolchain seems short but hard, so LGTM

[dave_cheney.net, 2012-12-21 04:35:25]

*** Abandoned ***