Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(15)

Issue 6842118: Update tools/upload.py from Rietveld's copy. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by kpreid2
Modified:
13 years, 7 months ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

codereview.appspot.com now 301 redirects to HTTPS, which is probably a good thing, but the version of upload.py we're using doesn't like it. * Update tools/upload.py to the latest version from the Rietveld repository, since we haven't done so in ages: <http://code.google.com/p/rietveld/source/browse/upload.py?spec=svnf66cc9030489ea92a2e699a0f1a68a854f1d064c&r=f66cc9030489ea92a2e699a0f1a68a854f1d064c> * Explicitly specify https: in appspot.py because even the new version of upload.py appears, from a quick review, to be defaulting to http:. * upload.py has also renamed the fields of an issue; change appspot.py to match. 'Message' is now 'Title' and 'Description' is now 'Message'. Includes backwards compatibility for old .appspot-change files. If you are reading this and it is not mangled, then uploading a review using these changes to the tools worked. @r5167

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1217 lines, -269 lines) Patch
M tools/appspot.py View 16 chunks +43 lines, -32 lines 0 comments Download
M tools/upload.py View 47 chunks +1174 lines, -237 lines 0 comments Download

Messages

Total messages: 2
kpreid2
13 years, 7 months ago (2012-11-29 19:56:15 UTC) #1
felix8a
13 years, 7 months ago (2012-11-29 20:02:04 UTC) #2
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b