Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(42)

Issue 6842079: Install pygobject override (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 2 months ago by Daiki Ueno
Modified:
12 years, 10 months ago
Reviewers:
shawn.p.huang
Base URL:
git@github.com:ibus/ibus.git@master
Visibility:
Public.

Description

Install pygobject override To mitigate the gap between the old python binding and pygobject, add wrapper to some classes. BUG=none

Patch Set 1 #

Patch Set 2 : fix LookupTable constructor and add Text #

Patch Set 3 : add tests and more overrides #

Total comments: 10

Patch Set 4 : add license headers #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -42 lines) Patch
M bindings/Makefile.am View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
A + bindings/pygobject/Makefile.am View 1 2 3 2 chunks +24 lines, -14 lines 0 comments Download
A + bindings/pygobject/gi/__init__.py View 1 2 3 2 chunks +8 lines, -14 lines 0 comments Download
A bindings/pygobject/gi/overrides/IBus.py View 1 2 3 1 chunk +234 lines, -0 lines 0 comments Download
A + bindings/pygobject/gi/overrides/__init__.py View 1 2 3 2 chunks +8 lines, -14 lines 0 comments Download
A bindings/pygobject/test-override-ibus.py View 1 2 3 1 chunk +123 lines, -0 lines 0 comments Download
M configure.ac View 1 2 2 chunks +15 lines, -0 lines 2 comments Download

Messages

Total messages: 7
Daiki Ueno
This is not intended for 1.5, but RFC.
13 years, 2 months ago (2012-11-21 07:17:59 UTC) #1
Peng
On 2012/11/21 07:17:59, Daiki Ueno wrote: > This is not intended for 1.5, but RFC. ...
13 years, 2 months ago (2012-11-21 14:30:24 UTC) #2
Daiki Ueno
On 2012/11/21 14:30:24, Peng wrote: > On 2012/11/21 07:17:59, Daiki Ueno wrote: > > This ...
13 years, 2 months ago (2012-11-22 07:11:31 UTC) #3
Peng
lgtm. please add license headers. Thanks. https://codereview.appspot.com/6842079/diff/6002/bindings/pygobject/Makefile.am File bindings/pygobject/Makefile.am (right): https://codereview.appspot.com/6842079/diff/6002/bindings/pygobject/Makefile.am#newcode1 bindings/pygobject/Makefile.am:1: NULL = license ...
13 years, 2 months ago (2012-11-22 15:30:53 UTC) #4
Daiki Ueno
https://codereview.appspot.com/6842079/diff/6002/bindings/pygobject/Makefile.am File bindings/pygobject/Makefile.am (right): https://codereview.appspot.com/6842079/diff/6002/bindings/pygobject/Makefile.am#newcode1 bindings/pygobject/Makefile.am:1: NULL = On 2012/11/22 15:30:53, Peng wrote: > license ...
13 years, 2 months ago (2012-11-22 22:55:04 UTC) #5
Peng
https://codereview.appspot.com/6842079/diff/3006/configure.ac File configure.ac (right): https://codereview.appspot.com/6842079/diff/3006/configure.ac#newcode365 configure.ac:365: [enable_pygobject=yes],[enable_pygobject=no]) Can we always report error if the user ...
12 years, 10 months ago (2013-03-25 15:44:50 UTC) #6
Daiki Ueno
12 years, 10 months ago (2013-03-26 09:19:48 UTC) #7
Message was sent while issue was closed.
https://codereview.appspot.com/6842079/diff/3006/configure.ac
File configure.ac (right):

https://codereview.appspot.com/6842079/diff/3006/configure.ac#newcode365
configure.ac:365: [enable_pygobject=yes],[enable_pygobject=no])
On 2013/03/25 15:44:50, Peng wrote:
> Can we always report error if the user system does not have pygobject
installed,
> unless --disable-pygobject is passed to ./configure?

Makes sense, given that ibus-setup doesn't work without pygobject.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b