Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1151)

Issue 6842061: Add original resources back and update code to match (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by robertphillips
Modified:
12 years ago
Reviewers:
DerekS
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

This CL adds an Icons sub-directory (beneath debugger/QT) to hold the restored .png icons. The qrc_SkIcons.cpp and SkDebuggerGUI.cpp files needed to be updated for the new resource "locations".

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+335 lines, -327 lines) Patch
A debugger/QT/Icons/.qrc View 1 chunk +16 lines, -0 lines 0 comments Download
A debugger/QT/Icons/blank.png View Binary file 0 comments Download
debugger/QT/Icons/blank.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/breakpoint.png View Binary file 0 comments Download
debugger/QT/Icons/breakpoint.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/breakpoint_16x16.png View Binary file 0 comments Download
debugger/QT/Icons/breakpoint_16x16.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/delete.png View Binary file 0 comments Download
debugger/QT/Icons/delete.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/doit.bat View 1 chunk +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/inspector.png View Binary file 0 comments Download
debugger/QT/Icons/inspector.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/next.png View Binary file 0 comments Download
debugger/QT/Icons/next.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/pause.png View Binary file 0 comments Download
debugger/QT/Icons/pause.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/play.png View Binary file 0 comments Download
debugger/QT/Icons/play.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/previous.png View Binary file 0 comments Download
debugger/QT/Icons/previous.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/reload.png View Binary file 0 comments Download
debugger/QT/Icons/reload.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/rewind.png View Binary file 0 comments Download
debugger/QT/Icons/rewind.png View 0 chunks +1 line, -0 lines 0 comments Download
A debugger/QT/Icons/skia.png View Binary file 0 comments Download
debugger/QT/Icons/skia.png View 0 chunks +1 line, -0 lines 0 comments Download
M debugger/QT/SkDebuggerGUI.cpp View 8 chunks +16 lines, -16 lines 0 comments Download
M debugger/QT/qrc_SkIcons.cpp View 15 chunks +290 lines, -311 lines 0 comments Download

Messages

Total messages: 4
robertphillips
12 years ago (2012-11-17 16:16:26 UTC) #1
robertphillips
Although the new qrc_SkIcons.cpp file was generated with QT 4.8.3 I have verified that it ...
12 years ago (2012-11-17 16:29:29 UTC) #2
DerekS
lgtm. Thanks for restoring these!
12 years ago (2012-11-19 13:41:40 UTC) #3
robertphillips
12 years ago (2012-11-19 17:39:59 UTC) #4
committed as 6484
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b