Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(934)

Issue 6842051: In SkBitmapHeap, defer adding owners for new bitmaps. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by Leon
Modified:
12 years ago
Reviewers:
junov
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

In SkBitmapHeap, defer adding owners for new bitmaps. When using an SkFlatDictionary to flatten shaders, the dictionary can try to insert a duplicate bitmap shader that uses a bitmap which has been removed from the bitmap heap. This change was originally suggested by junov in https://codereview.appspot.com/6713048/. Add a test to verify that deferring the owners works. Without the change to bitmap heap the test would fail (and crash in debug mode). Also remove an unused function from SkFlatDictionary. BUG=http://code.google.com/p/chromium/issues/detail?id=143923 Committed: https://code.google.com/p/skia/source/detail?r=6471

Patch Set 1 #

Patch Set 2 : remove unnecessary include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -15 lines) Patch
M gyp/tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmapHeap.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/core/SkBitmapHeap.cpp View 1 chunk +5 lines, -1 line 0 comments Download
M src/core/SkPictureFlat.h View 1 chunk +0 lines, -14 lines 0 comments Download
A tests/BitmapHeapTest.cpp View 1 1 chunk +96 lines, -0 lines 0 comments Download

Messages

Total messages: 2
Leon
12 years, 1 month ago (2012-11-14 20:47:20 UTC) #1
junov
12 years ago (2012-11-16 18:20:51 UTC) #2
On 2012/11/14 20:47:20, scroggo-work wrote:

lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b