Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(89)

Issue 68320043: Remove unused JsonML support from JS parse trees. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years ago by kpreid2
Modified:
12 years ago
Reviewers:
felix8a
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Context: <https://groups.google.com/d/topic/google-caja-discuss/RCHSAbB1-Zs/discussion> @r5669

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2093 lines) Patch
M build.xml View 3 chunks +0 lines, -7 lines 0 comments Download
M src/com/google/caja/parser/js/ArrayConstructor.java View 2 chunks +0 lines, -15 lines 0 comments Download
M src/com/google/caja/parser/js/Block.java View 2 chunks +0 lines, -21 lines 0 comments Download
M src/com/google/caja/parser/js/BooleanLiteral.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/BreakStmt.java View 2 chunks +0 lines, -9 lines 0 comments Download
M src/com/google/caja/parser/js/CaseStmt.java View 2 chunks +0 lines, -10 lines 0 comments Download
M src/com/google/caja/parser/js/CatchStmt.java View 2 chunks +0 lines, -10 lines 0 comments Download
M src/com/google/caja/parser/js/Conditional.java View 2 chunks +0 lines, -28 lines 0 comments Download
M src/com/google/caja/parser/js/ContinueStmt.java View 2 chunks +0 lines, -9 lines 0 comments Download
M src/com/google/caja/parser/js/DebuggerStmt.java View 2 chunks +0 lines, -8 lines 0 comments Download
M src/com/google/caja/parser/js/Declaration.java View 2 chunks +0 lines, -21 lines 0 comments Download
M src/com/google/caja/parser/js/DefaultCaseStmt.java View 2 chunks +0 lines, -9 lines 0 comments Download
M src/com/google/caja/parser/js/Directive.java View 3 chunks +1 line, -12 lines 0 comments Download
M src/com/google/caja/parser/js/DirectivePrologue.java View 2 chunks +0 lines, -10 lines 0 comments Download
M src/com/google/caja/parser/js/DoWhileLoop.java View 2 chunks +0 lines, -9 lines 0 comments Download
M src/com/google/caja/parser/js/Expression.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/parser/js/ExpressionStmt.java View 2 chunks +0 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/js/FinallyStmt.java View 2 chunks +0 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/js/ForEachLoop.java View 2 chunks +0 lines, -12 lines 0 comments Download
M src/com/google/caja/parser/js/ForLoop.java View 2 chunks +0 lines, -13 lines 0 comments Download
M src/com/google/caja/parser/js/FunctionConstructor.java View 2 chunks +0 lines, -33 lines 0 comments Download
M src/com/google/caja/parser/js/FunctionDeclaration.java View 2 chunks +0 lines, -12 lines 0 comments Download
M src/com/google/caja/parser/js/GetterProperty.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/Identifier.java View 3 chunks +1 line, -15 lines 0 comments Download
D src/com/google/caja/parser/js/JsonMLCompatible.java View 1 chunk +0 lines, -103 lines 0 comments Download
D src/com/google/caja/parser/js/JsonMLConverter.java View 1 chunk +0 lines, -465 lines 0 comments Download
D src/com/google/caja/parser/js/JsonMLParser.java View 1 chunk +0 lines, -46 lines 0 comments Download
M src/com/google/caja/parser/js/LabeledStatement.java View 2 chunks +0 lines, -12 lines 0 comments Download
M src/com/google/caja/parser/js/LabeledStmtWrapper.java View 2 chunks +0 lines, -6 lines 0 comments Download
M src/com/google/caja/parser/js/MultiDeclaration.java View 2 chunks +0 lines, -12 lines 0 comments Download
M src/com/google/caja/parser/js/NoChildren.java View 2 chunks +0 lines, -3 lines 0 comments Download
M src/com/google/caja/parser/js/Noop.java View 2 chunks +0 lines, -7 lines 0 comments Download
M src/com/google/caja/parser/js/NullLiteral.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/NumberLiteral.java View 2 chunks +0 lines, -22 lines 0 comments Download
M src/com/google/caja/parser/js/ObjProperty.java View 1 chunk +1 line, -2 lines 0 comments Download
M src/com/google/caja/parser/js/ObjectConstructor.java View 2 chunks +0 lines, -8 lines 0 comments Download
M src/com/google/caja/parser/js/Operation.java View 2 chunks +0 lines, -128 lines 0 comments Download
M src/com/google/caja/parser/js/Parser.java View 2 chunks +0 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/js/Reference.java View 2 chunks +0 lines, -21 lines 0 comments Download
M src/com/google/caja/parser/js/RegexpLiteral.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/RenderedExpression.java View 2 chunks +0 lines, -7 lines 0 comments Download
M src/com/google/caja/parser/js/ReturnStmt.java View 2 chunks +0 lines, -9 lines 0 comments Download
M src/com/google/caja/parser/js/SetterProperty.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/Statement.java View 1 chunk +1 line, -1 line 0 comments Download
M src/com/google/caja/parser/js/StringLiteral.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/SwitchStmt.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/ThrowStmt.java View 2 chunks +0 lines, -8 lines 0 comments Download
M src/com/google/caja/parser/js/TranslatedCode.java View 2 chunks +0 lines, -4 lines 0 comments Download
M src/com/google/caja/parser/js/TryStmt.java View 2 chunks +0 lines, -18 lines 0 comments Download
M src/com/google/caja/parser/js/ValueProperty.java View 2 chunks +0 lines, -11 lines 0 comments Download
M src/com/google/caja/parser/js/WhileLoop.java View 2 chunks +0 lines, -9 lines 0 comments Download
M src/com/google/caja/parser/js/WithStmt.java View 2 chunks +0 lines, -8 lines 0 comments Download
M tests/com/google/caja/parser/ParseTreeNodeTest.java View 2 chunks +0 lines, -3 lines 0 comments Download
D tests/com/google/caja/parser/js/JsonMLCompatibleTest.java View 1 chunk +0 lines, -821 lines 0 comments Download
D third_party/java/jsonml/LICENSE View 1 chunk +0 lines, -2 lines 0 comments Download
D third_party/java/jsonml/README View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6
kpreid2
12 years ago (2014-02-24 19:11:38 UTC) #1
felix8a
jsonml.jar removal isn't in the CL otherwise LGTM
12 years ago (2014-02-24 22:27:55 UTC) #2
kpreid2
On 2014/02/24 22:27:55, felix8a wrote: > jsonml.jar removal isn't in the CL > otherwise LGTM ...
12 years ago (2014-02-24 22:37:56 UTC) #3
felix8a
please also backport to es53
12 years ago (2014-02-24 23:53:40 UTC) #4
kpreid2
On 2014/02/24 23:53:40, felix8a wrote: > please also backport to es53 I backport things no ...
12 years ago (2014-02-25 00:09:57 UTC) #5
felix8a
12 years ago (2014-02-25 00:12:31 UTC) #6
Message was sent while issue was closed.
On 2014/02/25 00:09:57, kpreid2 wrote:
> On 2014/02/24 23:53:40, felix8a wrote:
> > please also backport to es53
> 
> I backport things no more than once a week, in order to reduce the noise of
> extra commits. Is there a reason to do them individually?

either way is fine by me. I tend to commit to both trunk and es53 at the same
time since I have all the knowledge of the change fresh in my head, and then I
can forget about it.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b