LGTM https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh#newcode4 gm/tests/run.sh:4: # TODO: for now, assumes that it is ...
https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh#newcode4 gm/tests/run.sh:4: # TODO: for now, assumes that it is being ...
https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh
File gm/tests/run.sh (right):
https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh#newcode4
gm/tests/run.sh:4: # TODO: for now, assumes that it is being run from .../trunk
On 2012/11/12 12:51:07, rmistry wrote:
> Should be easy to add a check that verifies that it is run from PWD=trunk and
> fails with a msg if it does not.
Better yet... I made it cd into the proper directory automatically.
I added a similar change to tools/tests/run.sh, and added that to this same CL.
Thanks for the nudge.
https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh#newcode8
gm/tests/run.sh:8:
On 2012/11/12 12:51:07, rmistry wrote:
> Might be useful verify that two arguments are provided and fail with a helpful
> msg if they are not.
Good idea. Done throughout here and tools/tests/run.sh.
Issue 6827068: Add a self-test for gm, similar to our self-test for skdiff.
(Closed)
Created 12 years ago by epoger
Modified 12 years ago
Reviewers: rmistry
Base URL: http://skia.googlecode.com/svn/trunk/
Comments: 5