Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1384)

Issue 6827068: Add a self-test for gm, similar to our self-test for skdiff. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 years, 7 months ago by epoger
Modified:
11 years, 7 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Add a self-test for gm, similar to our self-test for skdiff. Committed: https://code.google.com/p/skia/source/detail?r=6380

Patch Set 1 #

Total comments: 5

Patch Set 2 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1 line) Patch
A gm/tests/inputs/dashing-correct-images/4444/dashing.png View Binary file 0 comments Download
A gm/tests/inputs/dashing-correct-images/4444/dashing2.png View Binary file 0 comments Download
A gm/tests/inputs/dashing-incorrect-images/4444/dashing.png View Binary file 0 comments Download
A gm/tests/inputs/dashing-incorrect-images/4444/dashing2.png View Binary file 0 comments Download
A gm/tests/outputs/dashing-compared-against-correct/output-expected/command_line View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/dashing-compared-against-correct/output-expected/images/4444/dashing.png View Binary file 0 comments Download
A gm/tests/outputs/dashing-compared-against-correct/output-expected/images/4444/dashing2.png View Binary file 0 comments Download
A gm/tests/outputs/dashing-compared-against-correct/output-expected/return_value View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/dashing-compared-against-correct/output-expected/stdout View 1 chunk +5 lines, -0 lines 0 comments Download
A gm/tests/outputs/dashing-compared-against-incorrect/output-expected/command_line View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/dashing-compared-against-incorrect/output-expected/images/4444/dashing.png View Binary file 0 comments Download
A gm/tests/outputs/dashing-compared-against-incorrect/output-expected/images/4444/dashing2.png View Binary file 0 comments Download
A gm/tests/outputs/dashing-compared-against-incorrect/output-expected/return_value View 1 chunk +1 line, -0 lines 0 comments Download
A gm/tests/outputs/dashing-compared-against-incorrect/output-expected/stdout View 1 chunk +7 lines, -0 lines 0 comments Download
A gm/tests/run.sh View 1 1 chunk +62 lines, -0 lines 0 comments Download
M tools/tests/run.sh View 1 3 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 4
epoger
11 years, 7 months ago (2012-11-09 19:33:31 UTC) #1
rmistry
LGTM https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh#newcode4 gm/tests/run.sh:4: # TODO: for now, assumes that it is ...
11 years, 7 months ago (2012-11-12 12:51:07 UTC) #2
epoger
https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh File gm/tests/run.sh (right): https://codereview.appspot.com/6827068/diff/1/gm/tests/run.sh#newcode4 gm/tests/run.sh:4: # TODO: for now, assumes that it is being ...
11 years, 7 months ago (2012-11-12 18:05:16 UTC) #3
rmistry
11 years, 7 months ago (2012-11-12 18:45:38 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b