Issue 6827060: code review 6827060: runtime/race: add Windows support

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6827060: code review 6827060: runtime/race: add Windows support (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 5 months ago by dvyukov

Modified:
12 years, 5 months ago

Reviewers:

CC:
rsc, golang-dev

Visibility:
Public.

Description

runtime/race: add Windows support This is copy of https://codereview.appspot.com/6810080 but sent from another account (dvyukov@gmail.com is not in CONTRIBUTORS).

Patch Set 1 #

Patch Set 2 : diff -r b661b713984f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r b661b713984f https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r ff7ca53f4433 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r ff7ca53f4433 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 6 : diff -r ff7ca53f4433 https://dvyukov%40google.com@code.google.com/p/go/ #

Created: 12 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -3 lines)			Patch
M	src/cmd/go/build.go	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/pkg/runtime/race/race.go	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A	src/pkg/runtime/race/race_windows_amd64.syso	View	1	Binary file		0 comments	Download
M	src/run.bat	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

dvyukov

Hello rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/

12 years, 5 months ago (2012-11-07 19:58:55 UTC) #1

dvyukov

*** Submitted as http://code.google.com/p/go/source/detail?r=ca94b72025c5 *** runtime/race: add Windows support This is copy of https://codereview.appspot.com/6810080 but ...

12 years, 5 months ago (2012-11-07 19:59:28 UTC) #2

dvyukov

On 2012/11/07 19:59:28, dvyukov wrote: > *** Submitted as http://code.google.com/p/go/source/detail?r=ca94b72025c5 *** > > runtime/race: add ...

12 years, 5 months ago (2012-11-07 19:59:50 UTC) #3

LGTM

Expand All Messages | Collapse All Messages