Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(163)

Issue 6827058: code review 6827058: crypto/x509: fix DecryptPEMBlock (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 10 months ago by rog
Modified:
9 years, 10 months ago
Reviewers:
CC:
agl, agl1, golang-dev
Visibility:
Public.

Description

crypto/x509: fix DecryptPEMBlock The current implement can fail when the block size is not a multiple of 8 bytes. This CL makes it work, and also checks that the data is in fact a multiple of the block size.

Patch Set 1 #

Patch Set 2 : diff -r 57f70857cf91 https://go.googlecode.com/hg/ #

Patch Set 3 : diff -r 57f70857cf91 https://go.googlecode.com/hg/ #

Patch Set 4 : diff -r 25dcee3d220c https://go.googlecode.com/hg/ #

Patch Set 5 : diff -r 25dcee3d220c https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -24 lines) Patch
M src/pkg/crypto/x509/pem_decrypt.go View 1 5 chunks +23 lines, -24 lines 0 comments Download
M src/pkg/crypto/x509/pem_decrypt_test.go View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 3
rog
Hello agl@chromium.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://go.googlecode.com/hg/
9 years, 10 months ago (2012-11-07 15:06:50 UTC) #1
agl1
LGTM
9 years, 10 months ago (2012-11-07 15:11:35 UTC) #2
rog
9 years, 10 months ago (2012-11-07 15:19:58 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=b661b713984f ***

crypto/x509: fix DecryptPEMBlock

The current implement can fail when the
block size is not a multiple of 8 bytes.
This CL makes it work, and also checks that the
data is in fact a multiple of the block size.

R=agl, agl
CC=golang-dev
http://codereview.appspot.com/6827058
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b