Issue 6827053: Unit testing for SkTileGrid

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6827053: Unit testing for SkTileGrid (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years ago by junov1

Modified:
12 years ago

Reviewers:
Leon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Unit testing for SkTileGrid Committed: https://code.google.com/p/skia/source/detail?r=6331

Patch Set 1 #

Total comments: 1

Created: 12 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+63 lines, -0 lines)			Patch
M	gyp/tests.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/core/SkTileGrid.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/core/SkTileGrid.cpp	View	2 chunks	+5 lines, -0 lines	0 comments	Download
A	tests/TileGridTest.cpp	View	1 chunk	+55 lines, -0 lines	1 comment	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Leon

12 years ago (2012-11-06 20:03:05 UTC) #3

lgtm

https://codereview.appspot.com/6827053/diff/1/tests/TileGridTest.cpp
File tests/TileGridTest.cpp (right):

https://codereview.appspot.com/6827053/diff/1/tests/TileGridTest.cpp#newcode29
tests/TileGridTest.cpp:29: REPORTER_ASSERT(reporter, grid.tile(1,1).count() ==
((tileMask & kBottomRight_Tile)? 1 : 0));
100 columns.

Expand All Messages | Collapse All Messages