Issue 6826080: report max pixel error on failure, rather than the hex of the first mismatched pixel

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6826080: report max pixel error on failure, rather than the hex of the first mismatched pixel (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 7 months ago by reed1

Modified:
11 years, 7 months ago

Reviewers:
EricB

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

report max pixel error on failure, rather than the hex of the first mismatched pixel Committed: https://code.google.com/p/skia/source/detail?r=6365

Patch Set 2 : #

Created: 11 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -31 lines)			Patch
	M	gm/gmmain.cpp	View	1	20 chunks	+72 lines, -31 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

EricB

LGTM with nits https://codereview.appspot.com/6826080/diff/1/gm/gmmain.cpp File gm/gmmain.cpp (right): https://codereview.appspot.com/6826080/diff/1/gm/gmmain.cpp#newcode493 gm/gmmain.cpp:493: int* maxPixelError) { Nit: Should this ...

11 years, 7 months ago (2012-11-09 14:25:56 UTC) #2

reed1

11 years, 7 months ago (2012-11-09 14:50:43 UTC) #3

https://codereview.appspot.com/6826080/diff/1/gm/gmmain.cpp
File gm/gmmain.cpp (right):

https://codereview.appspot.com/6826080/diff/1/gm/gmmain.cpp#newcode518
gm/gmmain.cpp:518: int* maxPixelError) {
On 2012/11/09 14:25:56, EricB wrote:
> Alignment?

Done.

https://codereview.appspot.com/6826080/diff/1/gm/gmmain.cpp#newcode570
gm/gmmain.cpp:570: maxPixelError);
On 2012/11/09 14:25:56, EricB wrote:
> Alignment?

Done.

Expand All Messages | Collapse All Messages