Add 1 second interval before IME switcher is shown.

Add some milliseconds interval before IME switcher is shown.

[Peng, 2012-11-01 13:29:57]

https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala
File ui/gtk3/switcher.vala (right):

https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode77
ui/gtk3/switcher.vala:77: private uint m_popup_delay_time = 1000;
Is 1 seconds too long?

https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode168
ui/gtk3/switcher.vala:168: return true;
Maybe return false is better?

https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode171
ui/gtk3/switcher.vala:171: if (is_composited()) {
I did not notice it has a similar logic to delay show the switcher. Does it have
problem?

https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode312
ui/gtk3/switcher.vala:312: debug("restore_window_position %s %ld %ld\n",
debug_str,
weird style. Could you please change it to 
debug(...
    debug_str, m_root_x, m_root_y);

or

debug(....,
      ...
      ...
      ...);

[fujiwara, 2012-11-02 02:10:19]

On 2012/11/01 13:29:57, Peng wrote:
> https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala
> File ui/gtk3/switcher.vala (right):
> 
> https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode77
> ui/gtk3/switcher.vala:77: private uint m_popup_delay_time = 1000;
> Is 1 seconds too long?

OK, changed it to 400 millisecs.

> 
> https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode168
> ui/gtk3/switcher.vala:168: return true;
> Maybe return false is better?

Agreed.

> 
> https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode171
> ui/gtk3/switcher.vala:171: if (is_composited()) {
> I did not notice it has a similar logic to delay show the switcher. Does it
have
> problem?

I have noticed it but it does not work because composite is disabled.
Now I removed that code.

> 
> https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode312
> ui/gtk3/switcher.vala:312: debug("restore_window_position %s %ld %ld\n",
> debug_str,
> weird style. Could you please change it to 
> debug(...
>     debug_str, m_root_x, m_root_y);
> 
> or
> 
> debug(....,
>       ...
>       ...
>       ...);

I think the original format is used in GNOME but now I updated it to narrow the
line width.

[Peng, 2012-11-02 14:52:37]

lgtm. Please try to test it with all desktop envs (gnome, kde and etc), before
landing it. Thanks.

On 2012/11/02 02:10:19, fujiwara wrote:
> On 2012/11/01 13:29:57, Peng wrote:
> > https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala
> > File ui/gtk3/switcher.vala (right):
> > 
> >
https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode77
> > ui/gtk3/switcher.vala:77: private uint m_popup_delay_time = 1000;
> > Is 1 seconds too long?
> 
> OK, changed it to 400 millisecs.
> 
> > 
> >
https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode168
> > ui/gtk3/switcher.vala:168: return true;
> > Maybe return false is better?
> 
> Agreed.
> 
> > 
> >
https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode171
> > ui/gtk3/switcher.vala:171: if (is_composited()) {
> > I did not notice it has a similar logic to delay show the switcher. Does it
> have
> > problem?
> 
> I have noticed it but it does not work because composite is disabled.
> Now I removed that code.
> 
> > 
> >
https://codereview.appspot.com/6826045/diff/1/ui/gtk3/switcher.vala#newcode312
> > ui/gtk3/switcher.vala:312: debug("restore_window_position %s %ld %ld\n",
> > debug_str,
> > weird style. Could you please change it to 
> > debug(...
> >     debug_str, m_root_x, m_root_y);
> > 
> > or
> > 
> > debug(....,
> >       ...
> >       ...
> >       ...);
> 
> I think the original format is used in GNOME but now I updated it to narrow
the
> line width.