Issue 6822076: Add alignment to basic blocks.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6822076: Add alignment to basic blocks. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by chrisha

Modified:
11 years, 6 months ago

Reviewers:
Roger McFarlane, Siggi

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add alignment to basic blocks. A further CL will plumb this into the block builder. BUG= Committed: https://code.google.com/p/sawbuck/source/detail?r=1218

Patch Set 1 #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+60 lines, -18 lines)			Patch
M	syzygy/block_graph/basic_block.h	View	3 chunks	+11 lines, -0 lines	0 comments	Download
M	syzygy/block_graph/basic_block.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	syzygy/block_graph/basic_block_assembly_func.asm	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	syzygy/block_graph/basic_block_decomposer.cc	View	2 chunks	+12 lines, -0 lines	0 comments	Download
M	syzygy/block_graph/basic_block_decomposer_unittest.cc	View	9 chunks	+11 lines, -1 line	0 comments	Download
M	syzygy/block_graph/basic_block_test_util.cc	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	syzygy/reorder/basic_block_optimizer_unittest.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	syzygy/reorder/transforms/basic_block_layout_transform_unittest.cc	View	5 chunks	+10 lines, -10 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Thanks, committing!

Expand All Messages | Collapse All Messages