Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(214)

Issue 6822072: code review 6822072: net/http: fix data race in test (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 2 months ago by dvyukov
Modified:
9 years, 2 months ago
Reviewers:
CC:
golang-dev, dfc, rsc
Visibility:
Public.

Description

net/http: fix data race in test The issue is that server still sends body, when client closes the fd. Fixes issue 4329.

Patch Set 1 #

Patch Set 2 : diff -r 0167b45ce063 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r 0167b45ce063 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r 8a65cc8e918e https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M src/pkg/net/http/fs_test.go View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4
dvyukov
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
9 years, 2 months ago (2012-11-02 14:27:04 UTC) #1
dfc
LGTM. More and more I wish there was a finaliser on res.Body() that panic'd if ...
9 years, 2 months ago (2012-11-02 15:24:49 UTC) #2
rsc
LGTM
9 years, 2 months ago (2012-11-02 20:21:58 UTC) #3
dvyukov
9 years, 2 months ago (2012-11-02 20:31:18 UTC) #4
*** Submitted as http://code.google.com/p/go/source/detail?r=311b51675518 ***

net/http: fix data race in test
The issue is that server still sends body,
when client closes the fd.
Fixes issue 4329.

R=golang-dev, dave, rsc
CC=golang-dev
http://codereview.appspot.com/6822072
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b