GDI fonthost to serialize using correct font name.

GDI fonthost to serialize using correct font name.

[bungeman, 2012-10-31 19:29:28]

The change to SkFontHost_win.cpp is the real thing to review here, the changes
to SkPaint and SkTypeface are just to illustrate the issue with default font
selection.

When serialized, the other font hosts write out the name of the actual font used
by the system. This changes the GDI font host to do the same. Writing out the
name of the actual font used is highly desirable since if we were writing out
text based on glyph ids and end up with a different font, gibberish will result.

https://codereview.appspot.com/6822060/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.appspot.com/6822060/diff/1/include/core/SkTypeface.h#newco...
include/core/SkTypeface.h:194: static SkTypeface* GetDefaultTypeface();
Maybe this should be promoted to visible? This would allow users to set it
explicitly on paint, meaning that it would serialize this typeface in the paint,
instead of having the serialized paint marked as no/default typeface.

[reed1, 2012-10-31 19:45:16]

lgtm w/ suggestion for using SkAutoSTArray

https://codereview.appspot.com/6822060/diff/1/include/core/SkTypeface.h
File include/core/SkTypeface.h (right):

https://codereview.appspot.com/6822060/diff/1/include/core/SkTypeface.h#newco...
include/core/SkTypeface.h:194: static SkTypeface* GetDefaultTypeface();
On 2012/10/31 19:29:28, bungeman wrote:
> Maybe this should be promoted to visible? This would allow users to set it
> explicitly on paint, meaning that it would serialize this typeface in the
paint,
> instead of having the serialized paint marked as no/default typeface.

I agree. Tho we should add good docs about what it promises to return, and that
it *doesn't* change the refcnt on the returned object (unlike Create)

https://codereview.appspot.com/6822060/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.appspot.com/6822060/diff/1/src/ports/SkFontHost_win.cpp#ne...
src/ports/SkFontHost_win.cpp:1348: 
How about

SkAutoSTArray<64, TCHAR> fontName(fontNameLen + 1);

https://codereview.appspot.com/6822060/diff/1/src/ports/SkFontHost_win.cpp#ne...
src/ports/SkFontHost_win.cpp:1352: if (0 == GetTextFace(deviceContext,
fontNameLen, fontName.begin())) {
fontName[0] = 0;

[bungeman, 2012-10-31 20:41:01]

Will think about the default typeface issues and possibly try fixing that later.

https://codereview.appspot.com/6822060/diff/1/src/ports/SkFontHost_win.cpp
File src/ports/SkFontHost_win.cpp (right):

https://codereview.appspot.com/6822060/diff/1/src/ports/SkFontHost_win.cpp#ne...
src/ports/SkFontHost_win.cpp:1348: 
On 2012/10/31 19:45:16, reed1 wrote:
> How about
> 
> SkAutoSTArray<64, TCHAR> fontName(fontNameLen + 1);

Done.

https://codereview.appspot.com/6822060/diff/1/src/ports/SkFontHost_win.cpp#ne...
src/ports/SkFontHost_win.cpp:1352: if (0 == GetTextFace(deviceContext,
fontNameLen, fontName.begin())) {
On 2012/10/31 19:45:16, reed1 wrote:
> fontName[0] = 0;

Done.

[bungeman, 2012-10-31 20:59:04]

Committed revision 6227.