Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(19)

Issue 6822046: Remove VS2008/VS2010 conditional logic. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 9 months ago by chrisha
Modified:
12 years, 9 months ago
Reviewers:
Roger McFarlane, Siggi
CC:
sawbuck-changes_googlegroups.com
Base URL:
http://sawbuck.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove VS2008/VS2010 conditional logic. As of the last DEPS roll we now only support VS2010, so I've removed the conditional logic for VS2008 support. BUG= Committed: https://code.google.com/p/sawbuck/source/detail?r=1201

Patch Set 1 #

Patch Set 2 : Addressed siggi's nit. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -47 lines) Patch
M syzygy/pe/decomposer.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M syzygy/pe/decomposer_unittest.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M syzygy/pe/dia_browser_unittest.cc View 2 chunks +1 line, -9 lines 0 comments Download
M syzygy/pe/dia_util.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M syzygy/pe/pe.gyp View 1 2 chunks +2 lines, -9 lines 0 comments Download
M syzygy/pe/pe_file_parser_unittest.cc View 1 chunk +2 lines, -10 lines 0 comments Download

Messages

Total messages: 4
chrisha
PTAL.
12 years, 9 months ago (2012-10-29 14:41:57 UTC) #1
Siggi
nice - lgtm. Maybe also address these while you're at it? C:\src\syzygy\src\syzygy>git grep -i msdia ...
12 years, 9 months ago (2012-10-29 14:53:43 UTC) #2
chrisha
> Maybe also address these while you're at it? > > C:\src\syzygy\src\syzygy>git grep -i msdia ...
12 years, 9 months ago (2012-10-29 15:00:15 UTC) #3
Roger McFarlane
12 years, 9 months ago (2012-10-29 15:18:15 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b