Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(30)

Issue 6821100: code review 6821100: net: add more tests for protocol specific methods (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by mikio
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev, bradfitz
Visibility:
Public.

Description

net: add more tests for protocol specific methods

Patch Set 1 #

Patch Set 2 : diff -r 34142c2654fd https://code.google.com/p/go #

Patch Set 3 : diff -r 34142c2654fd https://code.google.com/p/go #

Patch Set 4 : diff -r 34142c2654fd https://code.google.com/p/go #

Total comments: 3

Patch Set 5 : diff -r e9a8a01f5d33 https://code.google.com/p/go #

Total comments: 4

Patch Set 6 : diff -r e9a8a01f5d33 https://code.google.com/p/go #

Total comments: 1

Patch Set 7 : diff -r e9a8a01f5d33 https://code.google.com/p/go #

Patch Set 8 : diff -r e9a8a01f5d33 https://code.google.com/p/go #

Patch Set 9 : diff -r e9a8a01f5d33 https://code.google.com/p/go #

Unified diffs Side-by-side diffs Delta from patch set Stats (+206 lines, -19 lines) Patch
M src/pkg/net/protoconn_test.go View 1 2 3 4 5 6 7 8 chunks +206 lines, -19 lines 0 comments Download

Messages

Total messages: 13
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
9 years, 7 months ago (2012-11-09 12:22:41 UTC) #1
mikio
Hello golang-dev@googlegroups.com (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2012-11-09 14:05:50 UTC) #2
bradfitz
https://codereview.appspot.com/6821100/diff/3002/src/pkg/net/protoconn_test.go File src/pkg/net/protoconn_test.go (right): https://codereview.appspot.com/6821100/diff/3002/src/pkg/net/protoconn_test.go#newcode26 src/pkg/net/protoconn_test.go:26: ln.SetDeadline(time.Now().Add(100 * time.Millisecond)) can you make this faster or ...
9 years, 7 months ago (2012-11-09 15:54:54 UTC) #3
mikio
On Sat, Nov 10, 2012 at 12:54 AM, <bradfitz@golang.org> wrote: > https://codereview.appspot.com/6821100/diff/3002/src/pkg/net/protoconn_test.go#newcode26 > src/pkg/net/protoconn_test.go:26: ln.SetDeadline(time.Now().Add(100 ...
9 years, 7 months ago (2012-11-09 17:56:31 UTC) #4
mikio
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2012-11-10 02:36:17 UTC) #5
bradfitz
https://codereview.appspot.com/6821100/diff/8002/src/pkg/net/protoconn_test.go File src/pkg/net/protoconn_test.go (right): https://codereview.appspot.com/6821100/diff/8002/src/pkg/net/protoconn_test.go#newcode46 src/pkg/net/protoconn_test.go:46: case "plan9", "windows": are these TODOs or intentional? add ...
9 years, 7 months ago (2012-11-10 02:41:45 UTC) #6
mikio
thanks for the comment. PTAL. https://codereview.appspot.com/6821100/diff/8002/src/pkg/net/protoconn_test.go File src/pkg/net/protoconn_test.go (right): https://codereview.appspot.com/6821100/diff/8002/src/pkg/net/protoconn_test.go#newcode46 src/pkg/net/protoconn_test.go:46: case "plan9", "windows": On ...
9 years, 7 months ago (2012-11-10 03:12:36 UTC) #7
bradfitz
https://codereview.appspot.com/6821100/diff/11001/src/pkg/net/protoconn_test.go File src/pkg/net/protoconn_test.go (right): https://codereview.appspot.com/6821100/diff/11001/src/pkg/net/protoconn_test.go#newcode16 src/pkg/net/protoconn_test.go:16: func notImplementedYet() bool { all the call sites look ...
9 years, 7 months ago (2012-11-10 04:03:21 UTC) #8
mikio
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2012-11-10 04:54:57 UTC) #9
mikio
On Sat, Nov 10, 2012 at 1:03 PM, <bradfitz@golang.org> wrote: > what if this were ...
9 years, 7 months ago (2012-11-10 05:26:49 UTC) #10
mikio
Hello golang-dev@googlegroups.com, bradfitz@golang.org (cc: golang-dev@googlegroups.com), Please take another look.
9 years, 7 months ago (2012-11-10 05:27:25 UTC) #11
bradfitz
LGTM
9 years, 7 months ago (2012-11-10 05:29:15 UTC) #12
mikio
9 years, 7 months ago (2012-11-10 05:34:43 UTC) #13
*** Submitted as http://code.google.com/p/go/source/detail?r=90e59cec3396 ***

net: add more tests for protocol specific methods

R=golang-dev, bradfitz
CC=golang-dev
http://codereview.appspot.com/6821100
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b