Issue 6821097: code review 6821097: ssh/test: don't kill process if it was never started

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6821097: code review 6821097: ssh/test: don't kill process if it was never started (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 11 months ago by iant

Modified:
13 years, 11 months ago

Reviewers:

CC:
golang-dev, dave_cheney.net

Visibility:
Public.

Description

go.crypto/ssh/test: don't kill process if it was never started This case arises if s.cmd.Start fails when called by server.Dial.

Patch Set 1 #

Patch Set 2 : diff -r 9207b1f5850c https://code.google.com/p/go.crypto #

Created: 13 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	ssh/test/test_unix_test.go	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

iant

Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto

13 years, 11 months ago (2012-11-08 16:25:29 UTC) #1

dave_cheney.net

LGTM. Thank you. Please rename the CL go.crypto/ssh/test: don't kill process if it was never ...

13 years, 11 months ago (2012-11-08 16:27:21 UTC) #2

iant

13 years, 11 months ago (2012-11-08 17:08:56 UTC) #3

*** Submitted as
http://code.google.com/p/go/source/detail?r=91815099edf1&repo=crypto ***

go.crypto/ssh/test: don't kill process if it was never started

This case arises if s.cmd.Start fails when called by
server.Dial.

R=golang-dev, dave
CC=golang-dev
http://codereview.appspot.com/6821097

Expand All Messages | Collapse All Messages