Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(18)
Issues Repositories Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 6821070: [api samples based-on-1.12] tasks-android-sample (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 1 month ago by yanivi
Modified:
13 years, 1 month ago
Reviewers:
rmistry
CC:
ngmiceli
Base URL:
https://code.google.com/p/google-api-java-client.samples/
Visibility:
Public.

Description

[api samples based-on-1.12] tasks-android-sample

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+662 lines, -284 lines) Patch
M calendar-android-sample/.project View 1 chunk +0 lines, -1 line 0 comments Download
M calendar-android-sample/instructions.html View 2 chunks +4 lines, -6 lines 0 comments Download
M tasks-android-sample/AndroidManifest.xml View 1 chunk +9 lines, -5 lines 0 comments Download
M tasks-android-sample/instructions.html View 5 chunks +61 lines, -34 lines 0 comments Download
A tasks-android-sample/lint.xml View 1 chunk +4 lines, -0 lines 0 comments Download
M tasks-android-sample/project.properties View 1 chunk +5 lines, -3 lines 0 comments Download
A tasks-android-sample/res/drawable/title_button.xml View 1 chunk +22 lines, -0 lines 1 comment Download
A tasks-android-sample/res/layout/calendarlist.xml View 1 chunk +41 lines, -0 lines 0 comments Download
A tasks-android-sample/res/menu/main_menu.xml View 1 chunk +13 lines, -0 lines 0 comments Download
A tasks-android-sample/res/values/colors.xml View 1 chunk +21 lines, -0 lines 0 comments Download
A tasks-android-sample/res/values/dimens.xml View 1 chunk +21 lines, -0 lines 0 comments Download
M tasks-android-sample/res/values/strings.xml View 1 chunk +21 lines, -0 lines 0 comments Download
A tasks-android-sample/res/values/styles.xml View 1 chunk +132 lines, -0 lines 0 comments Download
M tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/AsyncLoadTasks.java View 1 chunk +17 lines, -46 lines 0 comments Download
R tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/ClientCredentials.java View 1 chunk +0 lines, -43 lines 0 comments Download
A tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/CommonAsyncTask.java View 1 chunk +79 lines, -0 lines 0 comments Download
M tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/TasksSample.java View 1 chunk +119 lines, -146 lines 0 comments Download
A tasks-android-sample/src/main/java/com/google/api/services/samples/tasks/android/Utils.java View 1 chunk +93 lines, -0 lines 0 comments Download

Messages

Total messages: 4
yanivi
13 years, 1 month ago (2012-11-01 21:22:19 UTC) #1
rmistry
LGTM https://codereview.appspot.com/6821070/diff/1/tasks-android-sample/res/drawable/title_button.xml File tasks-android-sample/res/drawable/title_button.xml (right): https://codereview.appspot.com/6821070/diff/1/tasks-android-sample/res/drawable/title_button.xml#newcode3 tasks-android-sample/res/drawable/title_button.xml:3: Copyright 2012 Google Inc. Do not need this ...
13 years, 1 month ago (2012-11-02 13:04:29 UTC) #2
yanivi
On 2012/11/02 13:04:29, rmistry wrote: > LGTM > > https://codereview.appspot.com/6821070/diff/1/tasks-android-sample/res/drawable/title_button.xml > File tasks-android-sample/res/drawable/title_button.xml (right): > ...
13 years, 1 month ago (2012-11-02 13:16:16 UTC) #3
rmistry
13 years, 1 month ago (2012-11-02 13:17:12 UTC) #4 
On 2012/11/02 13:16:16, yanivi wrote:
> On 2012/11/02 13:04:29, rmistry wrote:
> > LGTM
> > 
> >
>
https://codereview.appspot.com/6821070/diff/1/tasks-android-sample/res/drawab...
> > File tasks-android-sample/res/drawable/title_button.xml (right):
> > 
> >
>
https://codereview.appspot.com/6821070/diff/1/tasks-android-sample/res/drawab...
> > tasks-android-sample/res/drawable/title_button.xml:3: Copyright 2012 Google
> Inc.
> > Do not need this line anymore here and in other files in this CL.
> 
> I talked to our lawyers again, and apparently  we still need the copyright
line
> for now.  Sigh.

LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b