Issue 6821060: Use D3D compiler optimization level 3.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6821060: Use D3D compiler optimization level 3. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 5 months ago by apatrick1

Modified:
13 years, 5 months ago

Reviewers:
kbr1

CC:
angleproject-review_googlegroups.com

Base URL:
http://angleproject.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Use D3D compiler optimization level 3. The is to try and fix some three.js lighting issues. It appears optimization level 0 has a loop unrolling bug. The compiler returns success but the shader does not work. All other optimization levels work. http://crbug.com/153105. Repro here: http://alteredqualia.com/tmp/tests/angle-issues/webgl_materials_normalmap_test.html Both heads should look the same. Committed: https://code.google.com/p/angleproject/source/detail?r=1383

Patch Set 1 #

Total comments: 1

Created: 13 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	src/build_angle.gypi	View		1 chunk	+0 lines, -1 line	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

apatrick1

https://codereview.appspot.com/6821060/diff/1/src/build_angle.gypi File src/build_angle.gypi (left): https://codereview.appspot.com/6821060/diff/1/src/build_angle.gypi#oldcode12 src/build_angle.gypi:12: 'ANGLE_COMPILE_OPTIMIZATION_LEVEL=D3DCOMPILE_OPTIMIZATION_LEVEL0', Level 3 is the default.

13 years, 5 months ago (2012-10-31 19:58:50 UTC) #1

LGTM

Expand All Messages | Collapse All Messages