Issue 6821055: Split off src\gpu-specific changes from image/surface CL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6821055: Split off src\gpu-specific changes from image/surface CL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 8 months ago by robertphillips

Modified:
11 years, 8 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

This moves the SkGpuDevice and render target validation changes out of https://codereview.appspot.com/6813055/ and into their own CL.

Patch Set 2 : Moved config check from GrGpuGL.cpp to GrGpu.cpp #

Created: 11 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -8 lines)			Patch
M	include/gpu/SkGpuDevice.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	src/gpu/GrGpu.cpp	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/gpu/SkGpuDevice.cpp	View		2 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

LGTM w/ a suggestion. https://codereview.appspot.com/6821055/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.appspot.com/6821055/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode933 src/gpu/gl/GrGpuGL.cpp:933: if (kUnknown_GrPixelConfig == desc.fConfig) { ...

11 years, 8 months ago (2012-10-31 13:42:00 UTC) #2

robertphillips

Committed as r6213 https://codereview.appspot.com/6821055/diff/1/src/gpu/gl/GrGpuGL.cpp File src/gpu/gl/GrGpuGL.cpp (right): https://codereview.appspot.com/6821055/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode933 src/gpu/gl/GrGpuGL.cpp:933: if (kUnknown_GrPixelConfig == desc.fConfig) { On ...

11 years, 8 months ago (2012-10-31 13:56:56 UTC) #3

bsalomon

11 years, 8 months ago (2012-10-31 13:57:30 UTC) #4

On 2012/10/31 13:56:56, robertphillips wrote:
> Committed as r6213
> 
> https://codereview.appspot.com/6821055/diff/1/src/gpu/gl/GrGpuGL.cpp
> File src/gpu/gl/GrGpuGL.cpp (right):
> 
>
https://codereview.appspot.com/6821055/diff/1/src/gpu/gl/GrGpuGL.cpp#newcode933
> src/gpu/gl/GrGpuGL.cpp:933: if (kUnknown_GrPixelConfig == desc.fConfig) {
> On 2012/10/31 13:42:00, bsalomon wrote:
> > Should we move this to GrGpu::createTexture()? It seems universal.
> 
> Done.

LGTM

Expand All Messages | Collapse All Messages