Issue 68210044: Add note to flow control about ENOBUFS for UDP on OSX/BSD

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 68210044: Add note to flow control about ENOBUFS for UDP on OSX/BSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by GvR

Modified:
11 years, 11 months ago

Reviewers:
yselivanov, gvrpython, haypo_gmail

Visibility:
Public.

More Reviews

Description

Add note to flow control about ENOBUFS for UDP on OSX/BSD

Patch Set 2 : Slight text improvements #

Total comments: 2

Patch Set 3 : Use markup to link ENOBUFS to its docs #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -2 lines)			Patch
	M	Doc/library/asyncio-protocol.rst	View	1 2	2 chunks	+11 lines, -2 lines	0 comments	Download

Messages

Total messages: 6

Expand All Messages | Collapse All Messages

yselivanov

https://codereview.appspot.com/68210044/diff/20001/Doc/library/asyncio-protocol.rst File Doc/library/asyncio-protocol.rst (right): https://codereview.appspot.com/68210044/diff/20001/Doc/library/asyncio-protocol.rst#newcode410 Doc/library/asyncio-protocol.rst:410: :class:`OSError` with errno set to ENOBUFS may or may ...

11 years, 11 months ago (2014-02-24 20:04:16 UTC) #2

GvR

11 years, 11 months ago (2014-02-24 20:10:52 UTC) #4

gvrpython

Can I have an LGTM? On Feb 24, 2014 12:10 PM, <gvanrossum@gmail.com> wrote: > > ...

11 years, 11 months ago (2014-02-24 22:25:22 UTC) #5

LGTM from me.
Well written and easy to understand.

Expand All Messages | Collapse All Messages