Issue 6820116: Merge to a single map_view template

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6820116: Merge to a single map_view template (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 3 months ago by dominic%measurementlab.net

Modified:
13 years, 3 months ago

Reviewers:
tiziana-mlab, claudiu.perta, tiziana

Base URL:
http://mlab-ns.googlecode.com/git

Visibility:
Public.

More Reviews

Description

Merge to a single map_view template

Patch Set 1 #

Created: 13 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+247 lines, -767 lines)			Patch
M	server/mlabns/handlers/admin.py	View	2 chunks	+4 lines, -5 lines	0 comments	Download
D	server/mlabns/templates/all_map_view_ipv4.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/all_map_view_ipv6.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/glasnost_map_view_ipv4.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/glasnost_map_view_ipv6.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/map.html	View	1 chunk	+0 lines, -33 lines	0 comments	Download
D	server/mlabns/templates/map_base.html	View	1 chunk	+0 lines, -237 lines	0 comments	Download
M	server/mlabns/templates/map_view.html	View	1 chunk	+243 lines, -276 lines	0 comments	Download
D	server/mlabns/templates/map_view_ipv4.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/map_view_ipv6.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/ndt_map_view_ipv4.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/ndt_map_view_ipv6.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/neubot_map_view_ipv4.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/neubot_map_view_ipv6.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/npad_map_view_ipv4.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download
D	server/mlabns/templates/npad_map_view_ipv6.html	View	1 chunk	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

tiziana

I did an high level review and it seems ok. But I'd prefer to have ...

13 years, 3 months ago (2012-11-08 17:14:01 UTC) #2

claudiu.perta

13 years, 3 months ago (2012-11-08 17:35:15 UTC) #4

On 2012/11/08 17:16:35, dominic-mlab wrote:

It seems fine to me.

Expand All Messages | Collapse All Messages