Convert clipPaths to clipRects where possible in pictureRecord

For raster (old/left is pre-conversion)

planet.mozilla.skp tile_256x256 c       1127.11     822.91    +304.20   +27.0%
pokemon-table.skp tile_256x256 c        508.56     370.50    +138.06   +27.1%

For GPU

planet.mozilla.skp tile_256x256_gpu c       1201.21     900.91    +300.30   +25.0%
pokemon-table.skp tile_256x256_gpu c        774.54     573.30    +201.24   +26.0%

It appears to be a wash for the rest of the SkPictures. I do not know the impact on the record time but believe it to be minimal.

Here are the conversion stats for the four SkPictures with the most clip paths:

pokemon-table.skp
934 Clip Paths converted to Clip Rect (out of 936)
planet.mozilla.skp
307 Clip Paths converted to Clip Rect (out of 307)
youtube.skp
0 Clip Paths converted to Clip Rect (out of 355)
worldjournal.skp
5 Clip Paths converted to Clip Rect (out of 221)

[Leon, 2012-11-06 21:30:41]

On 2012/11/06 21:26:59, robertphillips wrote:

FWIW, you can run "bench_pictures --mode record" to measure the record time.

The code lgtm

[robertphillips, 2012-11-06 21:56:31]

So it appears to be a wash or slightly better w.r.t. record time. The only
difference I really believe is the one for pokemon-table. These times were
generated with 400 repetitions.

python ..\skia.1\trunk\bench\bench_compare.py -o record-orig.txt -n
record-with-convert.txt
     milwaukeepolicenews.skp record c          0.12       0.16      -0.04  
-33.3%
                 simsimi.skp record c          0.12       0.16      -0.04  
-33.3%
                    xkcd.skp record c          0.23       0.27      -0.04  
-16.7%
                  pravda.skp record c          0.35       0.39      -0.04  
-11.1%
            cuteoverload.skp record c          1.13       1.21      -0.08   
-6.9%
                slashdot.skp record c          5.19       5.30      -0.12   
-2.3%
                  br.337.skp record c          0.47       0.47      +0.00   
+0.0%
cnn-michelle-obama-debate.skp record c          2.11       2.11      +0.00   
+0.0%
                    digg.skp record c          0.97       0.97      +0.00   
+0.0%
            gmail-thread.skp record c          0.47       0.47      +0.00   
+0.0%
                   gmail.skp record c          0.97       0.97      +0.00   
+0.0%
                 nytimes.skp record c          0.39       0.39      +0.00   
+0.0%
                 sahadan.skp record c          0.97       0.97      +0.00   
+0.0%
              techcrunch.skp record c          0.43       0.43      +0.00   
+0.0%
                theverge.skp record c          1.64       1.64      +0.00   
+0.0%
            worldjournal.skp record c          6.79       6.79      +0.00   
+0.0%
                 youtube.skp record c          3.98       3.94      +0.04   
+1.0%
                  gsp.ro.skp record c          3.55       3.51      +0.04   
+1.1%
googleblog.blogspot.co.uk.skp record c          1.68       1.64      +0.04   
+2.3%
           androidpolice.skp record c          3.78       3.63      +0.16   
+4.1%
                     wsj.skp record c          0.78       0.74      +0.04   
+5.0%
                  uk.wsj.skp record c          0.70       0.66      +0.04   
+5.6%
               vnexpress.skp record c          0.62       0.58      +0.04   
+6.3%
                  sfgate.skp record c          0.55       0.51      +0.04   
+7.1%
iphone.capitolvolkswagen.skp record c          0.43       0.39      +0.04   
+9.1%
                     mlb.skp record c          0.62       0.55      +0.08  
+12.5%
                   hs.fi.skp record c          0.94       0.82      +0.12  
+12.5%
          planet.mozilla.skp record c          5.97       4.99      +0.97  
+16.3%
 culturalsolutions.co.uk.skp record c          0.66       0.55      +0.12  
+17.6%
             spreadsheet.skp record c          0.66       0.55      +0.12  
+17.6%
            transformice.skp record c          0.39       0.31      +0.08  
+20.0%
      game.deksiam.in.th.skp record c          1.33       0.97      +0.35  
+26.5%
           pokemon-table.skp record c         10.22       7.41      +2.81  
+27.5%
            sms.personal.skp record c          0.12       0.08      +0.04  
+33.3%

[robertphillips, 2012-11-07 13:01:45]

committed as r6325