Add a new PictureRenderer that draws the picture then breaks up into tiles.

Add a new PictureRenderer that draws the picture then breaks up into tiles.

Committed: https://code.google.com/p/skia/source/detail?r=6333

[EricB, 2012-11-06 19:57:43]

Looks good, but with feature request.  Want Rob's approval as well.

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp
File tools/CopyTilesRenderer.cpp (right):

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp#new...
tools/CopyTilesRenderer.cpp:29: fLargeTileHeight = 4 * this->getTileHeight();
Can this multiple be passed in so that we can use a command-line flag?  Or maybe
we should set a maximum canvas size and then determine appropriate multipliers?

[robertphillips, 2012-11-06 20:31:16]

LGTM + some questions & nits

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp
File tools/CopyTilesRenderer.cpp (right):

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp#new...
tools/CopyTilesRenderer.cpp:29: fLargeTileHeight = 4 * this->getTileHeight();
4x4 is probably the correct default but I second having it configurable.

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp#new...
tools/CopyTilesRenderer.cpp:41: // Draw the picture
Do we need this clear? It looks like all the skps clear for themselves.

https://codereview.appspot.com/6820103/diff/1/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6820103/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:52: SkDebugf(
Why do we have '[]'s in the usage? If this needs correcting could you also fix
the spelling of 'minWidht'?

https://codereview.appspot.com/6820103/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:276: if (argv >= stop) {
need %s\n", mode); in logError

https://codereview.appspot.com/6820103/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6820103/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:221: if (argv >= stop) {
%s\n", mode);

[Leon, 2012-11-06 23:04:32]

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp
File tools/CopyTilesRenderer.cpp (right):

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp#new...
tools/CopyTilesRenderer.cpp:29: fLargeTileHeight = 4 * this->getTileHeight();
On 2012/11/06 20:31:16, robertphillips wrote:
> 4x4 is probably the correct default but I second having it configurable.

Done.

https://codereview.appspot.com/6820103/diff/1/tools/CopyTilesRenderer.cpp#new...
tools/CopyTilesRenderer.cpp:41: // Draw the picture
On 2012/11/06 20:31:16, robertphillips wrote:
> Do we need this clear? It looks like all the skps clear for themselves.

No. Removed.

https://codereview.appspot.com/6820103/diff/1/tools/bench_pictures_main.cpp
File tools/bench_pictures_main.cpp (right):

https://codereview.appspot.com/6820103/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:52: SkDebugf(
On 2012/11/06 20:31:16, robertphillips wrote:
> Why do we have '[]'s in the usage? 

I don't know why Keyar originally added them. Originally they had '%'s in them
(which I removed because they didn't get printed, being escape characters),
which may have been to show that a percentage could be used. The text states as
much, so I can remove entirely.

> If this needs correcting could you also fix
> the spelling of 'minWidht'?

Sure.

https://codereview.appspot.com/6820103/diff/1/tools/bench_pictures_main.cpp#n...
tools/bench_pictures_main.cpp:276: if (argv >= stop) {
On 2012/11/06 20:31:16, robertphillips wrote:
> need %s\n", mode); in logError 

Done.

https://codereview.appspot.com/6820103/diff/1/tools/render_pictures_main.cpp
File tools/render_pictures_main.cpp (right):

https://codereview.appspot.com/6820103/diff/1/tools/render_pictures_main.cpp#...
tools/render_pictures_main.cpp:221: if (argv >= stop) {
On 2012/11/06 20:31:16, robertphillips wrote:
> %s\n", mode);

Done.