Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(215)

Issue 6820094: Remove assert to allow Android bots (that don't support NPOT textures) to continue in Debug mode (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 1 month ago by robertphillips
Modified:
12 years, 1 month ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk/
Visibility:
Public.

Description

theverge.com uses a 4160x1 texture. On platforms that don't support NPOT textures this forces a resize of the texture. These platforms also typically have small max texture sizes which cause the subsequent allocation to fail. This CL simply removes the assert that the resized allocation never fails.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M src/gpu/GrContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3
robertphillips
12 years, 1 month ago (2012-11-05 20:58:00 UTC) #1
bsalomon
On 2012/11/05 20:58:00, robertphillips wrote: LGTM
12 years, 1 month ago (2012-11-05 20:58:42 UTC) #2
robertphillips
12 years, 1 month ago (2012-11-05 21:00:44 UTC) #3
committed as r6303
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b