CPP: Build a separate library for geocoding.

CPP: Build a separate library for geocoding.

Committed: https://code.google.com/p/libphonenumber/source/detail?r=549

[Shaopeng, 2012-11-01 01:19:57]

https://codereview.appspot.com/6820067/diff/6003/cpp/CMakeLists.txt
File cpp/CMakeLists.txt (right):

https://codereview.appspot.com/6820067/diff/6003/cpp/CMakeLists.txt#newcode425
cpp/CMakeLists.txt:425: set (GEOCODING_SOURCES
maybe GEOCODING_TEST_SOURCES

https://codereview.appspot.com/6820067/diff/6003/cpp/examples/geocoding_test.cc
File cpp/examples/geocoding_test.cc (right):

https://codereview.appspot.com/6820067/diff/6003/cpp/examples/geocoding_test....
cpp/examples/geocoding_test.cc:1: #include <cassert>
is this new examples/directory really necessary? Should test be in the test
directory instead?

Also, it needs to have copyright header and a description of what this file
does, and author info...

https://codereview.appspot.com/6820067/diff/6003/cpp/examples/geocoding_test....
cpp/examples/geocoding_test.cc:21:
PhoneNumberOfflineGeocoder().GetDescriptionForValidNumber(
since you haven't really validate this number, you should use the other method
instead.

[pliard1, 2012-12-05 15:26:07]

Thanks Shaopeng.

https://codereview.appspot.com/6820067/diff/6003/cpp/CMakeLists.txt
File cpp/CMakeLists.txt (right):

https://codereview.appspot.com/6820067/diff/6003/cpp/CMakeLists.txt#newcode425
cpp/CMakeLists.txt:425: set (GEOCODING_SOURCES
On 2012/11/01 01:19:57, Shaopeng wrote:
> maybe GEOCODING_TEST_SOURCES

Done. Good point.

https://codereview.appspot.com/6820067/diff/6003/cpp/examples/geocoding_test.cc
File cpp/examples/geocoding_test.cc (right):

https://codereview.appspot.com/6820067/diff/6003/cpp/examples/geocoding_test....
cpp/examples/geocoding_test.cc:1: #include <cassert>
On 2012/11/01 01:19:57, Shaopeng wrote:
> is this new examples/directory really necessary? Should test be in the test
> directory instead?
> 
> Also, it needs to have copyright header and a description of what this file
> does, and author info...

Seems that last time I created a new file was a while ago :) I moved it under
cpp/test/phonenumbers/geocoding/. Let me know if you can think of a better file
name.

https://codereview.appspot.com/6820067/diff/6003/cpp/examples/geocoding_test....
cpp/examples/geocoding_test.cc:21:
PhoneNumberOfflineGeocoder().GetDescriptionForValidNumber(
On 2012/11/01 01:19:57, Shaopeng wrote:
> since you haven't really validate this number, you should use the other method
> instead.

Done. Good point.

[Shaopeng, 2012-12-06 13:05:29]

LGTM

[pliard1, 2012-12-06 13:09:03]

On 2012/12/06 13:05:29, Shaopeng wrote:
> LGTM

Thanks Shaopeng! I will commit this soon.