Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1158)

Side by Side Diff: Makefile

Issue 6820047: Add yuidoc linter.
Patch Set: Add yuidoc linter. Created 12 years, 5 months ago
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | [revision details] » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 FILES=$(shell bzr ls -RV -k file | grep -v assets/ | grep -v app/templates.js | grep -v server.js) 1 FILES=$(shell bzr ls -RV -k file | grep -v assets/ | grep -v app/templates.js | grep -v server.js)
2 NODE_TARGETS=node_modules/chai node_modules/d3 node_modules/jshint \ 2 # After a successful "make" run, the NODE_TARGETS list can be regenerated with
3 » node_modules/yui node_modules/yuidoc 3 # this command (and then manually pasted in here):
4 # find node_modules -maxdepth 1 -mindepth 1 -type d -printf 'node_modules/%f '
5 NODE_TARGETS=node_modules/minimatch node_modules/cryptojs \
6 » node_modules/yuidocjs node_modules/chai node_modules/less \
7 » node_modules/.bin node_modules/node-markdown node_modules/rimraf \
8 » node_modules/mocha node_modules/d3 node_modules/graceful-fs \
9 » node_modules/should node_modules/jshint node_modules/expect.js \
10 » node_modules/express node_modules/yui node_modules/yuidoc
4 TEMPLATE_TARGETS=$(shell bzr ls -k file app/templates) 11 TEMPLATE_TARGETS=$(shell bzr ls -k file app/templates)
5 DATE=$(shell date -u) 12 DATE=$(shell date -u)
6 APPCACHE=app/assets/manifest.appcache 13 APPCACHE=app/assets/manifest.appcache
7 14
8 all: install 15 all: install
9 16
10 app/templates.js: $(TEMPLATE_TARGETS) bin/generateTemplates 17 app/templates.js: $(TEMPLATE_TARGETS) bin/generateTemplates
11 @./bin/generateTemplates 18 @./bin/generateTemplates
12 19
13 yuidoc: $(FILES) 20 yuidoc: $(FILES)
14 @node_modules/.bin/yuidoc -o yuidoc -x assets app 21 @node_modules/.bin/yuidoc -o yuidoc -x assets app
15 22
16 $(NODE_TARGETS): package.json 23 $(NODE_TARGETS): package.json
17 @npm install 24 @npm install
18 @#link depends 25 @#link depends
19 @ln -sf `pwd`/node_modules/yui ./app/assets/javascripts/ 26 @ln -sf `pwd`/node_modules/yui ./app/assets/javascripts/
20 @ln -sf `pwd`/node_modules/d3/d3.v2* ./app/assets/javascripts/ 27 @ln -sf `pwd`/node_modules/d3/d3.v2* ./app/assets/javascripts/
21 28
22 install: appcache $(NODE_TARGETS) app/templates.js yuidoc 29 install: appcache $(NODE_TARGETS) app/templates.js yuidoc
23 30
24 gjslint: virtualenv/bin/gjslint 31 gjslint: virtualenv/bin/gjslint
25 @virtualenv/bin/gjslint --strict --nojsdoc --jslint_error=all \ 32 @virtualenv/bin/gjslint --strict --nojsdoc --jslint_error=all \
26 » --custom_jsdoc_tags \ 33 » --custom_jsdoc_tags module,main,class,method,event,property,attribut e,submodule,namespace,extends,config,constructor,static,final,readOnly,writeOnce ,optional,required,param,return,for,type,private,protected,requires,default,uses ,example,chainable,deprecated,since,async,beta,bubbles,extension,extensionfor,ex tension_for \
27 » » property,default,since,method,module,submodule,namespace \
28 $(FILES) 34 $(FILES)
29 35
30 jshint: node_modules/jshint 36 jshint: node_modules/jshint
31 @node_modules/jshint/bin/hint $(FILES) 37 @node_modules/jshint/bin/hint $(FILES)
32 38
33 lint: gjslint jshint 39 yuidoc-lint: $(FILES)
40 » @bin/lint-yuidoc
41
42 lint: gjslint jshint yuidoc-lint
34 43
35 virtualenv/bin/gjslint virtualenv/bin/fixjsstyle: 44 virtualenv/bin/gjslint virtualenv/bin/fixjsstyle:
36 @virtualenv virtualenv 45 @virtualenv virtualenv
37 @virtualenv/bin/easy_install archives/closure_linter-latest.tar.gz 46 @virtualenv/bin/easy_install archives/closure_linter-latest.tar.gz
38 47
39 beautify: virtualenv/bin/fixjsstyle 48 beautify: virtualenv/bin/fixjsstyle
40 @virtualenv/bin/fixjsstyle --strict --nojsdoc --jslint_error=all $(FILES ) 49 @virtualenv/bin/fixjsstyle --strict --nojsdoc --jslint_error=all $(FILES )
41 50
42 prep: beautify lint 51 prep: beautify lint
43 52
(...skipping 17 matching lines...) Expand all
61 # A target used only for forcibly updating the appcache. 70 # A target used only for forcibly updating the appcache.
62 appcache-touch: 71 appcache-touch:
63 @touch manifest.appcache.in 72 @touch manifest.appcache.in
64 73
65 # This is the real target. appcache-touch needs to be executed before 74 # This is the real target. appcache-touch needs to be executed before
66 # appcache, and this provides the correct order. 75 # appcache, and this provides the correct order.
67 appcache-force: appcache-touch appcache 76 appcache-force: appcache-touch appcache
68 77
69 .PHONY: test lint beautify server install clean prep jshint gjslint \ 78 .PHONY: test lint beautify server install clean prep jshint gjslint \
70 appcache appcache-touch appcache-force 79 appcache appcache-touch appcache-force
OLDNEW
« no previous file with comments | « no previous file | [revision details] » ('j') | no next file with comments »

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b