Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(43)

Issue 6819113: code review 6819113: go.crypto/ssh: make tests work on OpenBSD (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 years, 7 months ago by jsing
Modified:
9 years, 7 months ago
Reviewers:
CC:
golang-dev, minux1, bradfitz, dfc
Visibility:
Public.

Description

go.crypto/ssh: make tests work on non-cgo platforms. user.Current() currently requires cgo - if an error is returned attempt to get the username from the environment.

Patch Set 1 #

Patch Set 2 : diff -r 9207b1f5850c https://code.google.com/p/go.crypto #

Patch Set 3 : diff -r 9207b1f5850c https://code.google.com/p/go.crypto #

Patch Set 4 : diff -r 9207b1f5850c https://code.google.com/p/go.crypto #

Total comments: 4

Patch Set 5 : diff -r 9207b1f5850c https://code.google.com/p/go.crypto #

Patch Set 6 : diff -r 91815099edf1 https://code.google.com/p/go.crypto #

Patch Set 7 : diff -r 91815099edf1 https://code.google.com/p/go.crypto #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -5 lines) Patch
M ssh/test/test_unix_test.go View 1 2 3 4 5 1 chunk +16 lines, -5 lines 0 comments Download

Messages

Total messages: 10
jsing
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://code.google.com/p/go.crypto
9 years, 7 months ago (2012-11-08 14:35:48 UTC) #1
minux1
LGTM
9 years, 7 months ago (2012-11-08 14:43:48 UTC) #2
bradfitz
Kinda gross and won't get updated when openbsd gets cgo. Can we query for cgo ...
9 years, 7 months ago (2012-11-08 15:34:11 UTC) #3
minux1
On Thu, Nov 8, 2012 at 11:34 PM, Brad Fitzpatrick <bradfitz@golang.org>wrote: > Kinda gross and ...
9 years, 7 months ago (2012-11-08 15:54:48 UTC) #4
bradfitz
On Thu, Nov 8, 2012 at 9:54 AM, minux <minux.ma@gmail.com> wrote: > > On Thu, ...
9 years, 7 months ago (2012-11-08 16:20:50 UTC) #5
jsing
On 9 November 2012 02:54, minux <minux.ma@gmail.com> wrote: > > On Thu, Nov 8, 2012 ...
9 years, 7 months ago (2012-11-08 16:26:39 UTC) #6
dfc
LGTM modulo comment. http://codereview.appspot.com/6819113/diff/5002/ssh/test/test_unix_test.go File ssh/test/test_unix_test.go (right): http://codereview.appspot.com/6819113/diff/5002/ssh/test/test_unix_test.go#newcode158 ssh/test/test_unix_test.go:158: // user.Current() currently requires CGO support ...
9 years, 7 months ago (2012-11-08 16:30:47 UTC) #7
bradfitz
LGTM https://codereview.appspot.com/6819113/diff/5002/ssh/test/test_unix_test.go File ssh/test/test_unix_test.go (right): https://codereview.appspot.com/6819113/diff/5002/ssh/test/test_unix_test.go#newcode169 ssh/test/test_unix_test.go:169: User: username, username() and pull the above out ...
9 years, 7 months ago (2012-11-08 16:33:24 UTC) #8
jsing
https://codereview.appspot.com/6819113/diff/5002/ssh/test/test_unix_test.go File ssh/test/test_unix_test.go (right): https://codereview.appspot.com/6819113/diff/5002/ssh/test/test_unix_test.go#newcode158 ssh/test/test_unix_test.go:158: // user.Current() currently requires CGO support - if it ...
9 years, 7 months ago (2012-11-11 15:47:07 UTC) #9
jsing
9 years, 7 months ago (2012-11-11 15:52:31 UTC) #10
*** Submitted as
http://code.google.com/p/go/source/detail?r=cf51e694ba75&repo=crypto ***

go.crypto/ssh: make tests work on non-cgo platforms.

user.Current() currently requires cgo - if an error is returned
attempt to get the username from the environment.

R=golang-dev, minux.ma, bradfitz, dave
CC=golang-dev
http://codereview.appspot.com/6819113
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b