Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(498)

Issue 6819101: Update obsolete comments in domado.js and narrow domitaModules scope. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 7 months ago by kpreid2
Modified:
13 years, 7 months ago
Reviewers:
metaweta
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

* domitaModules has no reason to be a global variable, so move it inside the scope function. * Update copyright date. * Node lists are no longer not live. * Domado may not be a “full implementation”, but it's not like we are specifically planning to replace it with something better.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M src/com/google/caja/plugin/domado.js View 4 chunks +6 lines, -7 lines 0 comments Download

Messages

Total messages: 3
kpreid2
13 years, 7 months ago (2012-11-06 22:02:28 UTC) #1
metaweta
lgtm
13 years, 7 months ago (2012-11-06 23:34:44 UTC) #2
kpreid2
13 years, 7 months ago (2012-11-07 00:01:49 UTC) #3
On 2012/11/06 23:34:44, metaweta wrote:
> lgtm

@r5139

Note: The simple move of the declaration of domitaModules into the function was
rejected by our linter, so I instead merged it with the conditional
initialization domitaModules = {} later down in the file.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b