Issue 6819068: Add an RPC interface definition for a logging service.

Issue 6819068: Add an RPC interface definition for a logging service. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by Roger McFarlane

Modified:
11 years, 6 months ago

Reviewers:
Sébastien Marchand, chrisha, Siggi

CC:
sawbuck-changes_googlegroups.com

Base URL:
http://sawbuck.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

Add an RPC interface definition for a logging service. R= siggi@chromium.org, sebmarchand@chromium.org Committed: https://code.google.com/p/sawbuck/source/detail?r=1215

Patch Set 2 : Fix a couple of typos #

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+127 lines, -2 lines)			Patch
A	syzygy/build/midl_rpc.gypi	View	1	1 chunk	+76 lines, -0 lines	0 comments	Download
A	syzygy/trace/rpc/logger_rpc.idl	View		1 chunk	+28 lines, -0 lines	0 comments	Download
M	syzygy/trace/rpc/rpc.gyp	View		4 chunks	+23 lines, -2 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

chrisha

lgtm with nits https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi File syzygy/build/midl_rpc.gypi (right): https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi#newcode19 syzygy/build/midl_rpc.gypi:19: # To use this include, define ...

11 years, 6 months ago (2012-11-01 20:14:11 UTC) #2

Sébastien Marchand

lgtm. https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi File syzygy/build/midl_rpc.gypi (right): https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi#newcode30 syzygy/build/midl_rpc.gypi:30: # Typically, your targer would then add <(SHARED_INTERMEDIATE_DIR) ...

11 years, 6 months ago (2012-11-01 20:17:19 UTC) #3

Roger McFarlane

11 years, 6 months ago (2012-11-02 14:21:22 UTC) #4

Thanks.

Committing.

https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi
File syzygy/build/midl_rpc.gypi (right):

https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi#n...
syzygy/build/midl_rpc.gypi:19: # To use this include, define the following
variables in you target.
On 2012/11/01 20:14:11, chrisha wrote:
> your*

Done.

https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi#n...
syzygy/build/midl_rpc.gypi:30: # Typically, your targer would then add
<(SHARED_INTERMEDIATE_DIR) to
On 2012/11/01 20:14:11, chrisha wrote:
> target*

Done.

https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi#n...
syzygy/build/midl_rpc.gypi:30: # Typically, your targer would then add
<(SHARED_INTERMEDIATE_DIR) to
On 2012/11/01 20:17:19, Sébastien Marchand wrote:
> target ?

Done.

https://codereview.appspot.com/6819068/diff/1004/syzygy/build/midl_rpc.gypi#n...
syzygy/build/midl_rpc.gypi:76: }
On 2012/11/01 20:14:11, chrisha wrote:
> Cool!

Thanks

https://codereview.appspot.com/6819068/diff/1004/syzygy/trace/rpc/rpc.gyp
File syzygy/trace/rpc/rpc.gyp (right):

https://codereview.appspot.com/6819068/diff/1004/syzygy/trace/rpc/rpc.gyp#new...
syzygy/trace/rpc/rpc.gyp:7: #     http://www.apache.org/licenses/LICENSE-2.0
On 2012/11/01 20:14:11, chrisha wrote:
> Hmm... when did this extra whitespace sneak in?

Indeed. IIRC, I've seen this line corrected in a couple of recent CLs.

Expand All Messages | Collapse All Messages