Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(66)

Issue 6819046: Pass GrCustomStage to key-generation functions and emitCode(). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
12 years, 2 months ago by bsalomon
Modified:
12 years, 2 months ago
Reviewers:
robertphillips
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/branches/gpu_dev/
Visibility:
Public.

Description

Pass GrCustomStage to key-generation functions and emitCode(). R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6182

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Pass GrCustomStage to key-generation functions and emitCode(). #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -223 lines) Patch
M gyp/gpu.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/gpu/GrBackendEffectFactory.h View 1 2 3 3 chunks +11 lines, -59 lines 2 comments Download
M include/gpu/GrEffect.h View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M include/gpu/GrEffectStage.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/effects/SkBlendImageFilter.cpp View 1 2 4 chunks +6 lines, -5 lines 0 comments Download
M src/effects/SkColorMatrixFilter.cpp View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M src/effects/SkLightingImageFilter.cpp View 1 2 4 chunks +7 lines, -7 lines 0 comments Download
M src/effects/SkMagnifierImageFilter.cpp View 1 2 5 chunks +5 lines, -6 lines 0 comments Download
M src/effects/SkMatrixConvolutionImageFilter.cpp View 1 2 4 chunks +7 lines, -6 lines 0 comments Download
M src/effects/SkMorphologyImageFilter.cpp View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M src/effects/SkTableColorFilter.cpp View 1 2 5 chunks +5 lines, -5 lines 0 comments Download
M src/effects/gradients/SkLinearGradient.cpp View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/effects/gradients/SkRadialGradient.cpp View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/effects/gradients/SkSweepGradient.cpp View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/effects/gradients/SkTwoPointConicalGradient.cpp View 1 2 5 chunks +7 lines, -5 lines 0 comments Download
M src/effects/gradients/SkTwoPointRadialGradient.cpp View 1 2 5 chunks +7 lines, -5 lines 0 comments Download
M src/gpu/GrDrawState.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrEffect.cpp View 1 2 2 chunks +7 lines, -1 line 0 comments Download
M src/gpu/effects/GrConfigConversionEffect.cpp View 1 2 3 chunks +5 lines, -3 lines 0 comments Download
M src/gpu/effects/GrConvolutionEffect.cpp View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M src/gpu/effects/GrSingleTextureEffect.cpp View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/effects/GrTextureDomainEffect.cpp View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLEffect.h View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 1 2 2 chunks +10 lines, -10 lines 0 comments Download
M src/gpu/gl/GrGLProgram.cpp View 1 2 8 chunks +16 lines, -15 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.h View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLShaderBuilder.cpp View 1 2 1 chunk +4 lines, -3 lines 0 comments Download
M src/gpu/gl/GrGpuGL.h View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL_program.cpp View 1 2 4 chunks +9 lines, -28 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 3 chunks +16 lines, -18 lines 0 comments Download

Messages

Total messages: 5
bsalomon
My earlier change passed GrEffectStage to setData() but GenKey() and emitCode() are still taking GrStage. ...
12 years, 2 months ago (2012-10-29 16:47:34 UTC) #1
robertphillips
LGTM
12 years, 2 months ago (2012-10-29 17:00:31 UTC) #2
bsalomon
Pass GrCustomStage to key-generation functions and emitCode(). R=robertphillips@google.com
12 years, 2 months ago (2012-10-29 19:20:46 UTC) #3
bsalomon
It wasn't possible to remove the dependence of GrEffectStage on GrBackendEffectFactory because it uses GrBackendEffectFactory::operator==(). ...
12 years, 2 months ago (2012-10-29 19:33:30 UTC) #4
robertphillips
12 years, 2 months ago (2012-10-29 19:37:30 UTC) #5
LGTM + 2 typo nits

https://codereview.appspot.com/6819046/diff/3005/include/gpu/GrBackendEffectF...
File include/gpu/GrBackendEffectFactory.h (right):

https://codereview.appspot.com/6819046/diff/3005/include/gpu/GrBackendEffectF...
include/gpu/GrBackendEffectFactory.h:18: is assigned a generation ID at
construction. The ID of the return of GrEffect::getFactory()
identifier

https://codereview.appspot.com/6819046/diff/3005/include/gpu/GrBackendEffectF...
include/gpu/GrBackendEffectFactory.h:20: getFactory(). GrEffect subclasses
should use the derived class GrTBackendEffectFactory that is
requires
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b