Implement user-defined name hashing.

Implement user-defined name hashing.

ANGLEBUG=315
Committed: https://code.google.com/p/angleproject/source/detail?r=1388

[Zhenyao Mo, 2012-11-08 23:15:22]

Please have a look.

[Zhenyao Mo, 2012-11-08 23:17:50]

On 2012/11/08 23:15:22, Zhenyao Mo wrote:
> Please have a look.

I did some testing manually with a bunch of shaders, using user defined
functions, multi level structs, etc.  All of them work as expected.

However, it's likely I missed some user cases.  Since this is all behind the
flag, so I want to get this part reviewed first.

Any further bug fixes should be easy to look at then.

[kbr1, 2012-11-09 19:56:54]

LGTM. Couple of minor questions / comments.

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase.cpp
File src/compiler/OutputGLSLBase.cpp (right):

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase....
src/compiler/OutputGLSLBase.cpp:460: TString fname =
TFunction::unmangleName(node->getName());
How about just using "functionName" for the variable, as in EOpFunctionCall,
below?

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase....
src/compiler/OutputGLSLBase.cpp:743: if (mSymbolTable.findBuiltIn(name) != NULL)
Any issues with situations where a user-defined variable is supposed to shadow a
built-in variable? Possibly not -- just asking.

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase....
src/compiler/OutputGLSLBase.cpp:750: if (mSymbolTable.findBuiltIn(name) != NULL
|| name == "main")
Similar question here.

[Zhenyao Mo, 2012-11-09 21:22:45]

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase.cpp
File src/compiler/OutputGLSLBase.cpp (right):

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase....
src/compiler/OutputGLSLBase.cpp:460: TString fname =
TFunction::unmangleName(node->getName());
On 2012/11/09 19:56:54, kbr1 wrote:
> How about just using "functionName" for the variable, as in EOpFunctionCall,
> below?

Done.

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase....
src/compiler/OutputGLSLBase.cpp:743: if (mSymbolTable.findBuiltIn(name) != NULL)
On 2012/11/09 19:56:54, kbr1 wrote:
> Any issues with situations where a user-defined variable is supposed to shadow
a
> built-in variable? Possibly not -- just asking.

Build-in variables starts with gl_, and are not valid user-defined names.

https://codereview.appspot.com/6818109/diff/2001/src/compiler/OutputGLSLBase....
src/compiler/OutputGLSLBase.cpp:750: if (mSymbolTable.findBuiltIn(name) != NULL
|| name == "main")
On 2012/11/09 19:56:54, kbr1 wrote:
> Similar question here.

Yes, in Shaders you can overwrite built-in functions such as texture2D, so here
as far as we use the mangled function name, we are fine.