Issue 6818102: Disable the IME switcher window with with switcher-delay-time == -1

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6818102: Disable the IME switcher window with with switcher-delay-time == -1 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 5 months ago by fujiwara

Modified:
11 years, 5 months ago

Reviewers:
shawn.p.huang

CC:
shawn.p.huang_gmail.com

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

More Reviews

Description

Disable IME switcher window when switcher-delay-time is less than 0

Patch Set 2 : Updated with message #2. #

Patch Set 3 : Fixed an xml parse error. #

Total comments: 1

Patch Set 4 : Updated with message #4. #

Created: 11 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+64 lines, -22 lines)			Patch
M	data/ibus.schemas.in	View	1 2	1 chunk	+6 lines, -1 line	0 comments	Download
M	ui/gtk3/panel.vala	View	1 2 3	6 chunks	+31 lines, -4 lines	0 comments	Download
M	ui/gtk3/switcher.vala	View		4 chunks	+27 lines, -17 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

Peng

https://codereview.appspot.com/6818102/diff/1/ui/gtk3/panel.vala File ui/gtk3/panel.vala (right): https://codereview.appspot.com/6818102/diff/1/ui/gtk3/panel.vala#newcode304 ui/gtk3/panel.vala:304: } Looks like it does not support change the ...

11 years, 5 months ago (2012-11-07 14:06:45 UTC) #2

fujiwara

On 2012/11/07 14:06:45, Peng wrote: > https://codereview.appspot.com/6818102/diff/1/ui/gtk3/panel.vala > File ui/gtk3/panel.vala (right): > > https://codereview.appspot.com/6818102/diff/1/ui/gtk3/panel.vala#newcode304 > ...

11 years, 5 months ago (2012-11-08 04:38:25 UTC) #3

Peng

11 years, 5 months ago (2012-11-08 21:36:06 UTC) #4

lgtm. with one comment

https://codereview.appspot.com/6818102/diff/6001/ui/gtk3/panel.vala
File ui/gtk3/panel.vala (right):

https://codereview.appspot.com/6818102/diff/6001/ui/gtk3/panel.vala#newcode332
ui/gtk3/panel.vala:332: if (m_engines.length > 2 && pressed &&
m_switcher_delay_time >= 0) {
I think check m_engines.length > 2 is not necessary.
Sometime users press ctrl+space is not for switching, they just want bring the
switch dialog to make check which engine is active.

Expand All Messages | Collapse All Messages