Issue 6818051: Allow default texture cache limit to be set within gyp.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6818051: Allow default texture cache limit to be set within gyp. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 6 months ago by DerekS

Modified:
11 years, 6 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Allow default texture cache limit to be set within gyp. Committed: https://code.google.com/p/skia/source/detail?r=6177

Created: 11 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -1 line)			Patch
M	gyp/common_variables.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	gyp/gpu.gyp	View		1 chunk	+5 lines, -0 lines	0 comments	Download
M	include/gpu/GrConfig.h	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
M	include/gpu/GrUserConfig.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

bsalomon

On 2012/10/29 18:26:04, DerekS wrote: Could you set the default value of GR_DEFAULT_TEXTURE_CACHE_MB_LIMIT in the ...

11 years, 6 months ago (2012-10-29 18:47:13 UTC) #2

bsalomon

11 years, 6 months ago (2012-10-29 19:19:48 UTC) #4

On 2012/10/29 19:13:52, DerekS wrote:
> updated per your comments

LGTM