Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1008)

Issue 6818049: code review 6818049: cmd/gc: racewalk: fix instrumentation of ninit lists (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
10 years, 1 month ago by dvyukov
Modified:
10 years, 1 month ago
Reviewers:
CC:
golang-dev, rsc, lvd1
Visibility:
Public.

Description

cmd/gc: racewalk: fix instrumentation of ninit lists The idea is to (1) process ninit of all nodes, and (2) put instrumentation of ninit into the nodes themselves (not the top-level statement ninit). Fixes issue 4304.

Patch Set 1 #

Patch Set 2 : diff -r bb4ee132b967 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 3 : diff -r bb4ee132b967 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 4 : diff -r bb4ee132b967 https://dvyukov%40google.com@code.google.com/p/go/ #

Patch Set 5 : diff -r d9a624c22a62 https://dvyukov%40google.com@code.google.com/p/go/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/cmd/gc/racewalk.c View 1 2 8 chunks +2 lines, -7 lines 0 comments Download

Messages

Total messages: 3
dvyukov
Hello golang-dev@googlegroups.com (cc: lvd@golang.org), I'd like you to review this change to https://dvyukov%40google.com@code.google.com/p/go/
10 years, 1 month ago (2012-10-29 18:18:44 UTC) #1
rsc
LGTM
10 years, 1 month ago (2012-11-01 16:58:12 UTC) #2
dvyukov
10 years, 1 month ago (2012-11-01 18:11:21 UTC) #3
*** Submitted as http://code.google.com/p/go/source/detail?r=6b2cbfacd3ab ***

cmd/gc: racewalk: fix instrumentation of ninit lists
The idea is to (1) process ninit of all nodes,
and (2) put instrumentation of ninit into the nodes themselves (not the
top-level statement ninit).
Fixes issue 4304.

R=golang-dev, rsc
CC=golang-dev, lvd
http://codereview.appspot.com/6818049
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b