Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(2093)

Issue 6817085: code review 6817085: cmd/5g: enable xtramodes optimisation (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 5 months ago by dfc
Modified:
1 year, 5 months ago
Reviewers:
CC:
remyoudompheng, rsc, golang-dev
Visibility:
Public.

Description

cmd/5g: enable xtramodes optimisation

xtramodes' C_PBIT optimisation transforms:

MOVW          0(R3),R1
ADD           $4,R3,R3

into:

MOVW.P        4(R3),R1

and the AADD optimisation tranforms:

ADD          R0,R1
MOVBU        0(R1),R0

into:

MOVBU        R0<<0(R1),R0

5g does not appear to generate sequences that
can be transformed by xtramodes' AMOVW.

Patch Set 1 #

Patch Set 2 : diff -r f781c447da6e https://code.google.com/p/go #

Patch Set 3 : diff -r f781c447da6e https://code.google.com/p/go #

Patch Set 4 : diff -r f781c447da6e https://go.googlecode.com/hg/ #

Total comments: 18

Patch Set 5 : diff -r 1369d7bb329d https://code.google.com/p/go #

Patch Set 6 : diff -r 1369d7bb329d https://code.google.com/p/go #

Patch Set 7 : diff -r 97b8514db41b https://go.googlecode.com/hg/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -23 lines) Patch
M src/cmd/5g/peep.c View 1 2 3 4 9 chunks +48 lines, -23 lines 0 comments Download

Messages

Total messages: 13
dfc
Hello golang-dev@googlegroups.com, I'd like you to review this change to https://go.googlecode.com/hg/
1 year, 5 months ago #1
remyoudompheng
igen is supposed to be there to avoid generating sequences that can be optimized like ...
1 year, 5 months ago #2
dfc
Heaps The pbit optimisation kicks in for the inc at the bottom of every range ...
1 year, 5 months ago #3
remyoudompheng
On 2012/11/5 Dave Cheney <dave@cheney.net> wrote: > Heaps > > The pbit optimisation kicks in ...
1 year, 5 months ago #4
dfc
Yes, I also use -S once I figure out the prog that is being transformed. ...
1 year, 5 months ago #5
remyoudompheng
I think it's an opportunity to make the intention more explicit. My comments suggestions may ...
1 year, 5 months ago #6
rsc
i'm happy once remy is https://codereview.appspot.com/6817085/diff/6001/src/cmd/5g/peep.c File src/cmd/5g/peep.c (right): https://codereview.appspot.com/6817085/diff/6001/src/cmd/5g/peep.c#newcode855 src/cmd/5g/peep.c:855: if(debug['h'] && p->as == ...
1 year, 5 months ago #7
remyoudompheng
http://codereview.appspot.com/6817085/diff/6001/src/cmd/5g/peep.c File src/cmd/5g/peep.c (right): http://codereview.appspot.com/6817085/diff/6001/src/cmd/5g/peep.c#newcode864 src/cmd/5g/peep.c:864: case AADD: 5g generates ADD.S/ADC for addition of int64's. ...
1 year, 5 months ago #8
dfc
On 07/11/2012, at 18:00, remyoudompheng@gmail.com wrote: > > http://codereview.appspot.com/6817085/diff/6001/src/cmd/5g/peep.c > File src/cmd/5g/peep.c (right): > > ...
1 year, 5 months ago #9
dfc
Thank you for your comments, I have tried to address as many of them as ...
1 year, 5 months ago #10
dfc
Hello remyoudompheng@gmail.com, rsc@golang.org (cc: golang-dev@googlegroups.com), I'd like you to review this change to https://code.google.com/p/go
1 year, 5 months ago #11
remyoudompheng
LGTM
1 year, 5 months ago #12
dfc
1 year, 5 months ago #13
*** Submitted as http://code.google.com/p/go/source/detail?r=422c00e8e022 ***

cmd/5g: enable xtramodes optimisation

xtramodes' C_PBIT optimisation transforms:

MOVW          0(R3),R1
ADD           $4,R3,R3

into:

MOVW.P        4(R3),R1

and the AADD optimisation tranforms:

ADD          R0,R1
MOVBU        0(R1),R0

into:

MOVBU        R0<<0(R1),R0

5g does not appear to generate sequences that
can be transformed by xtramodes' AMOVW.

R=remyoudompheng, rsc
CC=golang-dev
http://codereview.appspot.com/6817085
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1278:e6ce13d99bf5