Issue 6817077: Make morphology, convolution, and table color filter opt out of default texture matrices.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6817077: Make morphology, convolution, and table color filter opt out of default texture matrices. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Make morphology, convolution, and table color filter opt out of default texture matrices. Committed: https://code.google.com/p/skia/source/detail?r=6280

Patch Set 2 : #

Total comments: 3

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -26 lines)			Patch
M	include/gpu/GrBackendEffectFactory.h	View		2 chunks	+6 lines, -3 lines	1 comment	Download
M	src/effects/SkMorphologyImageFilter.cpp	View	1	7 chunks	+17 lines, -7 lines	0 comments	Download
M	src/effects/SkTableColorFilter.cpp	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/gpu/GrContext.cpp	View	1	1 chunk	+1 line, -1 line	2 comments	Download
M	src/gpu/effects/Gr1DKernelEffect.h	View		3 chunks	+12 lines, -1 line	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.h	View	1	1 chunk	+4 lines, -3 lines	0 comments	Download
M	src/gpu/effects/GrConvolutionEffect.cpp	View	1	6 chunks	+21 lines, -11 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

https://codereview.appspot.com/6817077/diff/1008/include/gpu/GrBackendEffectFactory.h File include/gpu/GrBackendEffectFactory.h (right): https://codereview.appspot.com/6817077/diff/1008/include/gpu/GrBackendEffectFactory.h#newcode35 include/gpu/GrBackendEffectFactory.h:35: kEffectKeyBits = 12, morphology was up against the limit. ...

12 years, 1 month ago (2012-11-02 19:59:42 UTC) #1

robertphillips

LGTM + 1 question https://codereview.appspot.com/6817077/diff/1008/src/gpu/GrContext.cpp File src/gpu/GrContext.cpp (right): https://codereview.appspot.com/6817077/diff/1008/src/gpu/GrContext.cpp#newcode201 src/gpu/GrContext.cpp:201: drawState->setRenderTarget(rt); Do we need sampleM ...

12 years, 1 month ago (2012-11-02 20:39:10 UTC) #2

bsalomon

12 years, 1 month ago (2012-11-02 20:46:13 UTC) #3

https://codereview.appspot.com/6817077/diff/1008/src/gpu/GrContext.cpp
File src/gpu/GrContext.cpp (right):

https://codereview.appspot.com/6817077/diff/1008/src/gpu/GrContext.cpp#newcod...
src/gpu/GrContext.cpp:201: drawState->setRenderTarget(rt);
nope, done.

On 2012/11/02 20:39:10, robertphillips wrote:
> Do we need sampleM anymore?

Expand All Messages | Collapse All Messages