Issue 6817053: Add isValid to GrContext, GrGpu and GrGpuGL

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6817053: Add isValid to GrContext, GrGpu and GrGpuGL (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 years, 11 months ago by robertphillips

Modified:
11 years, 11 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

The GPU image/surface uses a capability similar to this but it might be better placed in the derived GrGpu class (to hide backend assumptions about what makes a valid texture). One question is whether this should be visible at the GrContext level or if its highest exposure is as a pure virtual in GrGpu.

Patch Set 1 #

Patch Set 2 : Limit changes to GrGpuGL #

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	src/gpu/gl/GrGpuGL.cpp	View	1	1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

bsalomon

On 2012/10/30 14:47:20, robertphillips wrote: > PTAL LGTM

11 years, 11 months ago (2012-10-30 15:16:44 UTC) #3

committed as r6200

Expand All Messages | Collapse All Messages