Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(249)

Issue 6816107: Whitelists index and input on regexp matches in ES53. Fixes 1586. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 6 months ago by metaweta
Modified:
13 years, 6 months ago
Reviewers:
kpreid1, kpreid2
CC:
google-caja-discuss_googlegroups.com
Base URL:
http://google-caja.googlecode.com/svn/trunk/
Visibility:
Public.

Description

The input and index properties were whitelisted on the result of exec() calls, but not on e.g. String.match, which implicitly uses exec and returns the same kind of object.

Patch Set 1 #

Patch Set 2 : Whitelists index and input on regexp matches in ES53. Fixes 1586. #

Patch Set 3 : Whitelists index and input on regexp matches in ES53. Fixes 1586. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M src/com/google/caja/es53.js View 1 1 chunk +6 lines, -1 line 0 comments Download
M tests/com/google/caja/parser/quasiliteral/ES53RewriterTest.java View 1 2 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4
metaweta
13 years, 6 months ago (2012-11-08 18:46:25 UTC) #1
kpreid2
LGTM
13 years, 6 months ago (2012-11-08 18:50:18 UTC) #2
metaweta
Forgot to check for null. Added another test.
13 years, 6 months ago (2012-11-08 19:46:15 UTC) #3
kpreid2
13 years, 6 months ago (2012-11-08 19:47:15 UTC) #4
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b