Issue 6816104: Combine multiple intersecting rects in SkClipStack::Iter.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 6816104: Combine multiple intersecting rects in SkClipStack::Iter. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
12 years, 1 month ago by bsalomon

Modified:
12 years, 1 month ago

Reviewers:
robertphillips

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Combine multiple intersecting rects in SkClipStack::Iter. R=robertphillips@google.com Committed: https://code.google.com/p/skia/source/detail?r=6339

Patch Set 3 : #

Total comments: 5

Created: 12 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+235 lines, -14 lines)			Patch
M	include/core/SkClipStack.h	View	1	3 chunks	+10 lines, -2 lines	2 comments	Download
M	src/core/SkClipStack.cpp	View	1 2	1 chunk	+51 lines, -0 lines	0 comments	Download
M	src/gpu/GrClipMaskManager.cpp	View		6 chunks	+6 lines, -12 lines	3 comments	Download
M	tests/ClipStackTest.cpp	View	1 2	2 chunks	+168 lines, -0 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

bsalomon

https://codereview.appspot.com/6816104/diff/3001/src/gpu/GrClipMaskManager.cpp File src/gpu/GrClipMaskManager.cpp (left): https://codereview.appspot.com/6816104/diff/3001/src/gpu/GrClipMaskManager.cpp#oldcode122 src/gpu/GrClipMaskManager.cpp:122: if (SkRegion::kReplace_Op == clip->fOp) { Am I correct that ...

12 years, 1 month ago (2012-11-07 20:10:42 UTC) #1

robertphillips

LGTM + 1 question https://codereview.appspot.com/6816104/diff/3001/include/core/SkClipStack.h File include/core/SkClipStack.h (right): https://codereview.appspot.com/6816104/diff/3001/include/core/SkClipStack.h#newcode184 include/core/SkClipStack.h:184: SkDeque::Iter fIter; shouldn't the comment ...

12 years, 1 month ago (2012-11-07 21:15:51 UTC) #2

bsalomon

12 years, 1 month ago (2012-11-07 21:21:07 UTC) #3

https://codereview.appspot.com/6816104/diff/3001/include/core/SkClipStack.h
File include/core/SkClipStack.h (right):

https://codereview.appspot.com/6816104/diff/3001/include/core/SkClipStack.h#n...
include/core/SkClipStack.h:184: SkDeque::Iter      fIter;
On 2012/11/07 21:15:52, robertphillips wrote:
> shouldn't the comment be for nextCombined?

oops, yes.

https://codereview.appspot.com/6816104/diff/3001/src/gpu/GrClipMaskManager.cpp
File src/gpu/GrClipMaskManager.cpp (left):

https://codereview.appspot.com/6816104/diff/3001/src/gpu/GrClipMaskManager.cp...
src/gpu/GrClipMaskManager.cpp:122: if (SkRegion::kReplace_Op == clip->fOp) {
On 2012/11/07 21:15:52, robertphillips wrote:
> Sure.
> 

That sounds like a solid vote of confidence to me!

Expand All Messages | Collapse All Messages